New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch-MI probe by hotends.fr #14101
Touch-MI probe by hotends.fr #14101
Conversation
Marlin/src/inc/SanityCheck.h
Outdated
@@ -1046,6 +1047,27 @@ static_assert(Y_MAX_LENGTH >= Y_BED_SIZE, "Movement bounds (Y_MIN_POS, Y_MAX_POS | |||
#error "RACK_AND_PINION_PROBE requires Z_PROBE_DEPLOY_X and Z_PROBE_RETRACT_X." | |||
#endif | |||
|
|||
#if ENABLED(TOUCHMI_PROBE) | |||
#if ((MIN_PROBE_EDGE == 0) || !defined(Z_SAFE_HOMING) || !defined(PROBE_RETRACT_HEIGHT)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MIN_PROBE_EDGE
should not be required. The option only exists for the benefit of inductive and capacitive probes that give unusual readings if they are too close to the edge of the bed. If the probe can reach the whole bed, you don't need MIN_PROBE_EDGE
. And if you are using UBL, it doesn't care about the MIN_PROBE_EDGE
either. If the probe can't reach the edge, UBL just assumes you will fill in the points as the next bed leveling step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not 100% sure about this one, its maybe to return on the bed "X" if the magnet is on the right and a few mm outside the bed. But you can remove the extra check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Else, we have a second commit about the touchmi (tiny menu for manual Z probing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are Right.
MIN_PROBE_EDGE not required.
It was required with boundaries and FIX_MOUNTED_PROBE by hotends's documentation. As this is a new implantation, it can be removed. I tested it, and it works without. Thanks.
A simple Z probe using a magnet to deploy a probe see https://youtu.be/E7Ik9PbKPl0 for the sensor description...
This is a simple z-min sensor using a magnet to deploy a probe
see https://youtu.be/E7Ik9PbKPl0 for the sensor description...