Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delta_mm.e with zero extruders #15996

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

p3p
Copy link
Member

@p3p p3p commented Nov 25, 2019

Description

With 0 extruders the uninitialised delta_mm.e was used in some calculations which in rare cases could lead to a max_rate of 0. With ADAPTIVE_STEP_SMOOTHING enabled the silent error becomes obvious by freezing the board.

Related Issues

A comment by @MitchelBerberich on #15865

@sjasonsmith
Copy link
Contributor

I reproduced the original failure and verified this fix on both an SKR 1.3 (LPC1768) and SKR Mini E3 DIP (STM32F1).

@sjasonsmith
Copy link
Contributor

When reproducing this on my SKR 1.3, I couldn't get it to reboot when sending through Octoprint, I had to send directly through a serial terminal (per @p3p's suggestion).

I did notice that prior to this fix the behavior when sending through Octoprint was choppy, with frequent pauses in the movement. After this change it all seems smooth now. I can't tell if it was choppy when sending directly from my PC, because it would crash too soon to tell.

@MitchelBerberich
Copy link

Problem is solved for me, too: Compiled current version again without your fix => problem still there. Then applied your patch => everything runs smooth to the end of the gcode script. Thank you very much.

@thinkyhead thinkyhead merged commit c1aac3a into MarlinFirmware:bugfix-2.0.x Nov 26, 2019
@thinkyhead thinkyhead changed the title Fix delta_mm.e initialisation Fix delta_mm.e with zero extruders Nov 26, 2019
@p3p p3p deleted the pr_fix_freeze branch November 26, 2019 18:10
@anttix
Copy link
Contributor

anttix commented Dec 5, 2019

This seems to have fixed #15567 as well. Thank you!

LinoBarreca pushed a commit to LinoBarreca/Marlin that referenced this pull request Dec 18, 2019
philippniethammer pushed a commit to philippniethammer/Marlin that referenced this pull request Dec 21, 2019
christran206 pushed a commit to christran206/Marlin2.0-SKR-Mini-E3-1.2 that referenced this pull request Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants