Fix for MAX6675 MINTEMP errors #1680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SD-Card and MAX6675, both use hardware SPI. They used to conflict. For that reason the MAX code was puled out of the interrupt(#1402). Since then for different reasons either the code did not compile or failed wit an MINTEMP error. So a test was impossible until now. Here I eliminate the MIN-MAX-Temp-Test for extruder0 in the interrupt when we are using MAX6675. This will let us close #1226 and #1227 and we can close https://github.com/MarlinFirmware/Marlin/milestones/Bug%20Fixing%20Round%203
|
Ah, I see the temperature is being checked in |
|
Compare to #1674. I moved the temperature check next to the others, but left the temperature update routine where it was. This makes it possible for the temperature to be checked before being read, but it would just be "0" for the first iteration of the program loop when the printer first boots up, and should have no effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SD-Card and MAX6675, both use hardware SPI. They used to conflict.
For that reason the MAX code was puled out of the interrupt(#1402).
Since then for different reasons either the code did not compile or failed wit an MINTEMP error.
So a test was impossible until now.
Here I eliminate the MIN-MAX-Temp-Test for extruder0 in the interrupt when we are using MAX6675.
When tests are successful we can close #1226 and #1227 and https://github.com/MarlinFirmware/Marlin/milestones/Bug%20Fixing%20Round%203