Add MKS UI option (TFT_LITTLE_VGL_UI) #18071

makerbase-mks · 2020-05-22T12:46:18Z

Add LVGL GUI library for MKS Robin Nano.

Bugfix 2.0.x

thisiskeithb · 2020-05-22T12:52:18Z

LVGL looks promising. I'll be able to test this on a Robin Nano 1.2 once it passes checks 🙂

vivian-ng · 2020-05-23T00:25:03Z

This looks interesting, especially if it can be used with any of the displays and microcontrollers supported by LVGL. I had been hoping that Marlin would support ILI9341 displays for a while.

…ks_tft_18071

hobiseven · 2020-05-27T12:01:18Z

Gosh, seems we are quite a few to have LVGL running on our printers!!!
I also have my flavour of the port for STM32F103 on alfawise.

hobiseven · 2020-05-27T12:51:15Z

Hmm, this is SPI based, right?
On the STM32F103, for Alfawise, we have it going through FSMC / 16 bit parallel, with DMA in background mode. So likely to be a lot more responsive.

hobiseven · 2020-05-27T12:51:59Z

@vivian-ng And, yes, our alfawise flavour is since a while using ili9341

makerbase-mks · 2020-05-28T02:09:53Z

@hobiseven ，we have implemented LVGL in both SPI interface and FSMC interface.

looxonline · 2020-05-28T12:07:15Z

FSMC

Do any motherboards provide a breakout for the FSMC interface?

hobiseven · 2020-05-29T11:31:42Z

@makerbase-mks
Went on the facebook pages, to find one picture of LVGL gui. Can you share more pictures please?

thinkyhead · 2020-06-01T23:50:46Z

Did some cleanup. A few more hours of code cleanup will be needed.

…_vgl_ui_18071

vivian-ng · 2020-06-08T02:51:33Z

@makerbase-mks Is this implementation generic? Such that I can test it by defining TFT_LITTLE_VGL_UI or SPI_GRAPHICAL_TFT in Configuration.h, then the relevant pins in the pins file? Hoping to give it a try because I don't see any HAL-specific files being changed.

…_vgl_ui_18071

rhapsodyv · 2020-06-17T23:14:15Z

Marlin/src/HAL/STM32F1/../../inc/SanityCheck.h:691:4: error: #error "CUSTOM_STATUS_SCREEN_IMAGE requires a Graphical LCD."
   #error "CUSTOM_STATUS_SCREEN_IMAGE requires a Graphical LCD."

Do Conditionals_LCD.h needs update? Or am I doing something wrong?

I just changed from FSMC_GRAPHICAL_TFT to TFT_LITTLE_VGL_UI/SPI_GRAPHICAL_TFT, and it won't compile because of the graphical related defines I did.

rhapsodyv · 2020-06-17T23:56:13Z

Even disable all the graphical "dependent" features, I can't compile it. Now there're references to a folder that doesn't exist.

Or am I doing something wrong?

Stephane-Peel · 2020-06-18T09:58:54Z

I just changed from FSMC_GRAPHICAL_TFT to TFT_LITTLE_VGL_UI/SPI_GRAPHICAL_TFT, and it won't compile because of the graphical related defines I did.

The same for me...

rhapsodyv · 2020-06-18T22:38:10Z

@makerbase-mks @thinkyhead

thinkyhead · 2020-06-24T04:14:03Z

For a PR of this size and complexity, I prefer to leave it to the contributor to be the maintainer. We don't like to go on safaris to find bugs, so if there's some obvious typo causing a compile error, someone should drop us a set of Configuration files so we can just drop them into Marlin and compile to see the same error you see. Maybe it's easy to fix.

thisiskeithb · 2020-06-24T06:47:01Z

Here's a ready-to-build branch to view said errors.

I just put in PR #18401 to address the file include errors, but there are others that I'm unsure how to resolve (see PR for details).

rhapsodyv · 2020-06-24T11:33:52Z

I could get it compiling. But I got linker errors too.
And some fixes really points to missing things...
So, I decided to ask to thinkyhead and the author first.
Or at least someone that have this screen to test. I don’t have one.

thisiskeithb · 2020-06-24T12:13:03Z

I have a Robin Nano with TFT35 combo this LVGL PR is meant to run so I can easily test working code, but I couldn’t get it to compile before or after fixing the includes (again, see my PR for details).

Here’s the error output from the linked PR:

Log Output

Compiling .pio/build/mks_robin_nano35/src/src/lcd/extui/lib/mks_ui/printer_opration.cpp.o
*** [.pio/build/mks_robin_nano35/src/src/lcd/extui/lib/mks_ui/draw_about.cpp.o] Error 1
*** [.pio/build/mks_robin_nano35/src/src/lcd/extui/lib/mks_ui/draw_change_speed.cpp.o] Error 1
*** [.pio/build/mks_robin_nano35/src/src/lcd/extui/lib/mks_ui/draw_error_message.cpp.o] Error 1
*** [.pio/build/mks_robin_nano35/src/src/lcd/extui/lib/mks_ui/draw_dialog.cpp.o] Error 1
*** [.pio/build/mks_robin_nano35/src/src/lcd/extui/lib/mks_ui/draw_extrusion.cpp.o] Error 1
In file included from Marlin/src/lcd/extui/lib/mks_ui/draw_ui.h:48:0,
                 from Marlin/src/lcd/extui/lib/mks_ui/draw_opration.cpp:27:
Marlin/src/lcd/extui/lib/mks_ui/draw_error_message.h:28:41: error: variable or field 'lv_draw_error_message' declared void
 extern void lv_draw_error_message(PGM_P const msg);
                                         ^~~~~
Marlin/src/lcd/extui/lib/mks_ui/draw_error_message.h:28:35: error: 'PGM_P' was not declared in this scope
 extern void lv_draw_error_message(PGM_P const msg);
                                   ^~~~~
*** [.pio/build/mks_robin_nano35/src/src/lcd/extui/lib/mks_ui/draw_language.cpp.o] Error 1
In file included from Marlin/src/lcd/extui/lib/mks_ui/draw_ui.h:48:0,
                 from Marlin/src/lcd/extui/lib/mks_ui/draw_preHeat.cpp:27:
Marlin/src/lcd/extui/lib/mks_ui/draw_error_message.h:28:41: error: variable or field 'lv_draw_error_message' declared void
 extern void lv_draw_error_message(PGM_P const msg);
                                         ^~~~~
Marlin/src/lcd/extui/lib/mks_ui/draw_error_message.h:28:35: error: 'PGM_P' was not declared in this scope
 extern void lv_draw_error_message(PGM_P const msg);
                                   ^~~~~
*** [.pio/build/mks_robin_nano35/src/src/lcd/extui/lib/mks_ui/draw_opration.cpp.o] Error 1
In file included from Marlin/src/lcd/extui/lib/mks_ui/draw_ui.h:48:0,
                 from Marlin/src/lcd/extui/lib/mks_ui/draw_printing.cpp:27:
Marlin/src/lcd/extui/lib/mks_ui/draw_error_message.h:28:41: error: variable or field 'lv_draw_error_message' declared void
 extern void lv_draw_error_message(PGM_P const msg);
                                         ^~~~~
Marlin/src/lcd/extui/lib/mks_ui/draw_error_message.h:28:35: error: 'PGM_P' was not declared in this scope
 extern void lv_draw_error_message(PGM_P const msg);
                                   ^~~~~
In file included from Marlin/src/lcd/extui/lib/mks_ui/draw_ui.h:48:0,
                 from Marlin/src/lcd/extui/lib/mks_ui/draw_ready_print.cpp:36:
Marlin/src/lcd/extui/lib/mks_ui/draw_error_message.h:28:41: error: variable or field 'lv_draw_error_message' declared void
 extern void lv_draw_error_message(PGM_P const msg);
                                         ^~~~~
Marlin/src/lcd/extui/lib/mks_ui/draw_error_message.h:28:35: error: 'PGM_P' was not declared in this scope
 extern void lv_draw_error_message(PGM_P const msg);
                                   ^~~~~
*** [.pio/build/mks_robin_nano35/src/src/lcd/extui/lib/mks_ui/draw_preHeat.cpp.o] Error 1
In file included from Marlin/src/lcd/extui/lib/mks_ui/draw_ui.h:48:0,
                 from Marlin/src/lcd/extui/lib/mks_ui/draw_tool.cpp:27:
Marlin/src/lcd/extui/lib/mks_ui/draw_error_message.h:28:41: error: variable or field 'lv_draw_error_message' declared void
 extern void lv_draw_error_message(PGM_P const msg);
                                         ^~~~~
Marlin/src/lcd/extui/lib/mks_ui/draw_error_message.h:28:35: error: 'PGM_P' was not declared in this scope
 extern void lv_draw_error_message(PGM_P const msg);
                                   ^~~~~
*** [.pio/build/mks_robin_nano35/src/src/lcd/extui/lib/mks_ui/draw_printing.cpp.o] Error 1
*** [.pio/build/mks_robin_nano35/src/src/lcd/extui/lib/mks_ui/draw_ready_print.cpp.o] Error 1
*** [.pio/build/mks_robin_nano35/src/src/lcd/extui/lib/mks_ui/draw_tool.cpp.o] Error 1
Marlin/src/lcd/extui/lib/mks_ui/draw_ui.cpp:49:1: error: 'CFG_ITMES' does not name a type
 CFG_ITMES gCfgItems;
 ^~~~~~~~~
Marlin/src/lcd/extui/lib/mks_ui/draw_ui.cpp:50:1: error: 'UI_CFG' does not name a type
 UI_CFG uiCfg;
 ^~~~~~
Marlin/src/lcd/extui/lib/mks_ui/draw_ui.cpp:51:1: error: 'DISP_STATE_STACK' does not name a type; did you mean 'SPI_STATE_READY'?
 DISP_STATE_STACK disp_state_stack;
 ^~~~~~~~~~~~~~~~
 SPI_STATE_READY
Marlin/src/lcd/extui/lib/mks_ui/draw_ui.cpp:52:1: error: 'DISP_STATE' does not name a type; did you mean 'LS_DATE'?
 DISP_STATE disp_state = MAIN_UI;
 ^~~~~~~~~~
 LS_DATE
Marlin/src/lcd/extui/lib/mks_ui/draw_ui.cpp:53:1: error: 'DISP_STATE' does not name a type; did you mean 'LS_DATE'?
 DISP_STATE last_disp_state;
 ^~~~~~~~~~
 LS_DATE
compilation terminated due to -fmax-errors=5.
*** [.pio/build/mks_robin_nano35/src/src/lcd/extui/lib/mks_ui/draw_ui.cpp.o] Error 1

rhapsodyv · 2020-06-24T15:26:53Z

@thisiskeithb great. I will push my branch so you can test. Reach me in marlin discord, if you want. rhapsodyv

makerbase-mks added 6 commits May 11, 2020 20:34

Merge pull request #1 from MarlinFirmware/bugfix-2.0.x

aa595f5

Bugfix 2.0.x

Merge pull request #2 from MarlinFirmware/bugfix-2.0.x

d5d325c

Bugfix 2.0.x

Merge pull request #4 from MarlinFirmware/bugfix-2.0.x

d8d5c0f

Bugfix 2.0.x

Merge pull request #6 from MarlinFirmware/bugfix-2.0.x

a1055dd

Bugfix 2.0.x

Merge pull request #7 from MarlinFirmware/bugfix-2.0.x

8b349b1

Bugfix 2.0.x

Add color ui

cea1dc4

thinkyhead changed the title ~~Bugfix 2.0.x~~ Add MKS UI option (TFT_LITTLE_VGL_UI) May 22, 2020

thinkyhead added C: LCD & Controllers PR: New Feature labels May 22, 2020

thinkyhead and others added 3 commits May 25, 2020 20:05

Merge remote-tracking branch 'upstream/bugfix-2.0.x' into bf2_color_m…

13fb1d2

…ks_tft_18071

Move and clean up mks_ui

0ee706e

Update platformio.ini

195f175

thisiskeithb mentioned this pull request May 27, 2020

Support for TFT and touch screen - need feedback and testing #18129

Closed

Various cleanups, more needed

dae2578

thinkyhead and others added 6 commits June 1, 2020 18:52

Update MarlinCore.cpp

78df7d3

Clean, clean, clean

180470a

Update draw_dialog.cpp

20dd574

Update mks_hardware_test.cpp

4adc9c9

Apply FastIO

eca6834

Merge remote-tracking branch 'upstream/bugfix-2.0.x' into bf2_mks_tft…

1b8fd49

…_vgl_ui_18071

thinkyhead force-pushed the bugfix-2.0.x branch from 75f0041 to fe969ec Compare June 11, 2020 20:28

thinkyhead added 13 commits June 12, 2020 15:12

Merge remote-tracking branch 'upstream/bugfix-2.0.x' into bf2_mks_tft…

a20823b

…_vgl_ui_18071

Auto-format

21af96b

Apply some formatting

a372d6f

Merge remote-tracking branch 'upstream/bugfix-2.0.x' into bf2_mks_tft…

860b7fd

…_vgl_ui_18071

More one-liner options

ff7d015

Apply formatting

ffa822e

Apply more formatting

5a349b6

Update SPI_TFT.h

13d1560

Merge remote-tracking branch 'upstream/bugfix-2.0.x' into bf2_mks_tft…

105c9ad

…_vgl_ui_18071

Formatting...

f9db5e6

Merge remote-tracking branch 'upstream/bugfix-2.0.x' into bf2_mks_tft…

927afe0

…_vgl_ui_18071

etc

d58c6f6

Update Configuration.h

4ac9b04

thinkyhead merged commit 642112d into MarlinFirmware:bugfix-2.0.x Jun 16, 2020

thisiskeithb mentioned this pull request Jun 24, 2020

Fix MKS LVGL includes #18401

Closed

rhapsodyv added a commit to rhapsodyv/Marlin that referenced this pull request Jun 24, 2020

Fixes PR MarlinFirmware#18071 TFT_LITTLE_VGL_UI broken compilation

d1ad4fe

rhapsodyv mentioned this pull request Jun 24, 2020

Fixes PR #18071 TFT_LITTLE_VGL_UI broken compilation #18410

Merged

thisiskeithb mentioned this pull request Jun 25, 2020

Update MKS Robin Nano build environments #18417

Merged

jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020

Add MKS UI (TFT_LITTLE_VGL_UI) (MarlinFirmware#18071)

2b4e202

HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021

Add MKS UI (TFT_LITTLE_VGL_UI) (MarlinFirmware#18071)

5d702c5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add MKS UI option (TFT_LITTLE_VGL_UI) #18071

Add MKS UI option (TFT_LITTLE_VGL_UI) #18071

makerbase-mks commented May 22, 2020 •

edited

thisiskeithb commented May 22, 2020 •

edited

vivian-ng commented May 23, 2020

hobiseven commented May 27, 2020

hobiseven commented May 27, 2020 •

edited

hobiseven commented May 27, 2020 •

edited

makerbase-mks commented May 28, 2020

looxonline commented May 28, 2020

hobiseven commented May 29, 2020

thinkyhead commented Jun 1, 2020

vivian-ng commented Jun 8, 2020

rhapsodyv commented Jun 17, 2020 •

edited

rhapsodyv commented Jun 17, 2020

Stephane-Peel commented Jun 18, 2020

rhapsodyv commented Jun 18, 2020

thinkyhead commented Jun 24, 2020 •

edited

thisiskeithb commented Jun 24, 2020

rhapsodyv commented Jun 24, 2020

thisiskeithb commented Jun 24, 2020

rhapsodyv commented Jun 24, 2020

Add MKS UI option (TFT_LITTLE_VGL_UI) #18071

Add MKS UI option (TFT_LITTLE_VGL_UI) #18071

Conversation

makerbase-mks commented May 22, 2020 • edited

thisiskeithb commented May 22, 2020 • edited

vivian-ng commented May 23, 2020

hobiseven commented May 27, 2020

hobiseven commented May 27, 2020 • edited

hobiseven commented May 27, 2020 • edited

makerbase-mks commented May 28, 2020

looxonline commented May 28, 2020

hobiseven commented May 29, 2020

thinkyhead commented Jun 1, 2020

vivian-ng commented Jun 8, 2020

rhapsodyv commented Jun 17, 2020 • edited

rhapsodyv commented Jun 17, 2020

Stephane-Peel commented Jun 18, 2020

rhapsodyv commented Jun 18, 2020

thinkyhead commented Jun 24, 2020 • edited

thisiskeithb commented Jun 24, 2020

rhapsodyv commented Jun 24, 2020

thisiskeithb commented Jun 24, 2020

rhapsodyv commented Jun 24, 2020

makerbase-mks commented May 22, 2020 •

edited

thisiskeithb commented May 22, 2020 •

edited

hobiseven commented May 27, 2020 •

edited

hobiseven commented May 27, 2020 •

edited

rhapsodyv commented Jun 17, 2020 •

edited

thinkyhead commented Jun 24, 2020 •

edited