Prevent upgrading MAX31865 library to 1.2 #18089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am experimenting with a different change to platformio.ini to downgrade this only for the STM32F1 HAL, but that is still a work in progress. It seemed important to get something available quickly to un-break the build. |
I have posted the more extensive follow-up as PR #18099. If that is merged this is no longer necessary. I'll leave both up for now, as it provides the choice between a simple one-line change (this PR) or the more invasive solution (PR #18099). |
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
May 29, 2020
gromgit
pushed a commit
to gromgit/MKS-Robin-E3-E3D
that referenced
this pull request
Jun 2, 2020
Backport of MarlinFirmware/Marlin#18089 to 2.0.1
gromgit
pushed a commit
to gromgit/MKS-Robin-E3-E3D
that referenced
this pull request
Jun 2, 2020
Backport MarlinFirmware/Marlin#18089 to MKS base firmware
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new version of the MAX31865 libary depends upon a 3-argument version of
TwoWrite::requestFrom. This does not exist in the STM32F1 and possibly some other HALs.Benefits
Fixes builds, although I do not have the means to test functionality. If there was a particular reason this pointed to
masterrather than a release, then it would need to point to a particular commit.Related Issues
#18081