check for LCD_SET_PROGRESS_MANUALLY when using USE_M73_REMAINING_TIME #20751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjasonsmith
approved these changes
Jan 18, 2021
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 26, 2021
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Mar 11, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you enable USE_M73_REMAINING_TIME and SHOW_REMAINING_TIME and SDSUPPORT without enabling LCD_SET_PROGRESS_MANUALLY you get a compile error
marlinui_HD44780.cpp:711:35: error: 'class MarlinUI' has no member named 'get_remaining_time'
duration_t remaining = ui.get_remaining_time();
Requirements
A LCD and USE_M73_REMAINING_TIME and SHOW_REMAINING_TIME and SDSUPPORT enabled.
Benefits
Warns the user that USE_M73_REMAINING_TIME requires to enable LCD_SET_PROGRESS_MANUALLY
Related Issues
Was noticed in reprap forum https://reprap.org/forum/read.php?415,880392