add missing FORCE_SOFT_SPI for MKS_MINI_12864 on skr v1.3 #24940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellensp
changed the title
It took me a bit to figure out how this wasn't a dupe of the referenced "brother" PR 🙂. What factors are you using to determine which PRs should be backported to
I would assume most/all, but we're not doing that currently. |
|
The #24863 is not closing 2.0.x this is a rogue pr attempting to push 2.0.x into bugfix-2.1.x |
|
Ok. I am still curious why this single PR is being backported to |
|
Since 2.0.x and 2.1.x are both still being worked on I wanted both updated. But since these pr are being ignored for some reason... it all rather moot. |
thinkyhead
pushed a commit
that referenced
this pull request
Apr 16, 2023
thinkyhead
pushed a commit
that referenced
this pull request
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix 2.0.x brother PR to #24850
MKS_MINI_12864 on SKR v1.3 was found not to work.
#24848
This was traced back to PR #16349 accidently removing
#define FORCE_SOFT_SPI when adding support for ENDER2_STOCKDISPLAY
Requirements
MKS_MINI_12864 and BOARD_BTT_SKR_V1_3
Benefits
Display works as expected
Related Issues
#24848
#16349
#24850