LCD Bed Tramming Probe Loop Fix #26962
Conversation
|
The configuration defines |
thinkyhead
force-pushed
the
Bed-Tramming-Bugfix
branch
2 times, most recently
from
f3bff12
to
ea6b8f5
Compare
thinkyhead
force-pushed
the
Bed-Tramming-Bugfix
branch
from
ea6b8f5
to
4a7e126
Compare
| @@ -235,7 +228,7 @@ static void _lcd_goto_next_corner() { | |||
| } | |||
|
|
|||
| bool _lcd_bed_tramming_probe(const bool verify=false) { | |||
| if (verify) line_to_z(BED_TRAMMING_Z_HOP); // do clearance if needed | |||
| if (verify) line_to_z(current_position.z + (BED_TRAMMING_Z_HOP)); // do clearance if needed | |||
There was a problem hiding this comment.
Code like this will need to be tested since it may now need special handling for the first point. We don't want to just raise over the current height before we've moved down to the bed.
There was a problem hiding this comment.
Upon initial review this change seems to be safe and won't adversely affect behavior.
| ExtUI::setAxisPosition_mm(Z_MIN_POS + BED_TRAMMING_Z_HOP, ExtUI::Z); | ||
| } | ||
| if (BED_TRAMMING_Z_HOP) | ||
| ExtUI::setAxisPosition_mm(ExtUI::getAxisPosition_mm(ExtUI::Z) + (BED_TRAMMING_Z_HOP), ExtUI::Z); | ||
| ExtUI::setAxisPosition_mm(x, ExtUI::X); | ||
| ExtUI::setAxisPosition_mm(y, ExtUI::Y); |
There was a problem hiding this comment.
NOTE: These manual move methods are not ideal for this usage since they move only one axis at a time. The move to and from the center point ends up taking two moves instead of one. ExtUI should be extended with a method to move XY together (or this code should just use the motion.* functions directly).
Description
Previously, when using LCD Bed Tramming with a probe, if the bed was adjusted to trigger the probe, and the distance between the bed and extended probe was < BED_TRAMMING_Z_HOP, the probe (if servo or piston) would deploy and immediately trigger. This premature triggering would result in the probe deploying again to verify the change, and would be followed by an immediate trigger. This deploy and premature triggering would continue over and over.
This pull request resolves this issue by adding the BED_TRAMMING_Z_HOP to the current_position.z to gurantee clearance between the bed and probe to compensate for the change in distance between the bed and probe due to adjustment.
Related Issues
Resolves LCD Bed Tramming Probe Loop