Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃┕ Fix Nextion cstr/fstr typo #27071

Merged

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented May 9, 2024

Description

While running the build_all_examples script, I found that our Nextion TFT-based config would not build:

details:

Marlin/src/lcd/extui/nextion/nextion_extui.cpp: In function 'void ExtUI::onUserConfirmRequired(int, FSTR_P, FSTR_P)':
Marlin/src/lcd/extui/nextion/nextion_extui.cpp:64:27: error: 'cstr' was not declared in this scope
     onUserConfirmRequired(cstr);
                           ^~~~
Marlin/src/lcd/extui/nextion/nextion_extui.cpp:64:27: note: suggested alternative: 'fstr'
     onUserConfirmRequired(cstr);
                           ^~~~
                           fstr
*** [.pio/build/mega2560/src/src/lcd/extui/nextion/nextion_extui.cpp.o] Error 1
============================================================== [FAILED] Took 10.56 seconds ==============================================================

Environment    Status    Duration
-------------  --------  ------------
mega2560       FAILED    00:00:10.557
========================================================= 1 failed, 0 succeeded in 00:00:10.557 =========================================================
Failed

This appears to be an obvious typo & now matches the other extui changes made in #26539

Requirements

Any config with NEXTION_TFT.

Benefits

NEXTION_TFT-based configs will build.

Configurations

config/examples/Nextion

Related Issues

@thinkyhead thinkyhead merged commit 83b7e32 into MarlinFirmware:bugfix-2.1.x May 11, 2024
62 checks passed
@thisiskeithb thisiskeithb deleted the pr/fix_nextion_cstr_typo branch May 11, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants