Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 DISABLE_ENCODER => NO_BACK_MENU_ITEM #27180

Conversation

thisiskeithb
Copy link
Member

Description

Rename DISABLE_ENCODER flag to accurately reflect what it does.

cc: @EvilGremlin

Requirements

TFT_CLASSIC_UI or TFT_COLOR_UI with TOUCH_SCREEN

Benefits

Clearer flag name & description since it doesn't actually disable the encoder.

@thisiskeithb thisiskeithb force-pushed the pr/rename_disable_encoder_flag branch from 76b002b to 6b0f1f6 Compare June 16, 2024 16:37
@thisiskeithb thisiskeithb changed the title 🔨 DISABLE_ENCODER => DISABLE_BACK_MENU_ITEM 🔨 DISABLE_ENCODER => REMOVE_BACK_MENU_ITEM Jun 16, 2024
Rename flag to accurately reflect what it does.
@thisiskeithb thisiskeithb force-pushed the pr/rename_disable_encoder_flag branch from 6b0f1f6 to a6f0bcc Compare June 16, 2024 16:39
thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Jun 16, 2024
@thinkyhead thinkyhead changed the title 🔨 DISABLE_ENCODER => REMOVE_BACK_MENU_ITEM 🔨 DISABLE_ENCODER => NO_BACK_MENU_ITEM Jun 16, 2024
@thinkyhead
Copy link
Member

Affected configurations:

  • Elegoo/Neptune 2
  • Tronxy/D01/CXY-v6-191017 board

@thinkyhead thinkyhead merged commit ee8dada into MarlinFirmware:bugfix-2.1.x Jun 16, 2024
62 checks passed
@thisiskeithb thisiskeithb deleted the pr/rename_disable_encoder_flag branch June 16, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants