Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PROBE OFFSET FROM EXTRUDER comment section #3053

Merged

Conversation

jbrazio
Copy link
Contributor

@jbrazio jbrazio commented Feb 28, 2016

Apply the changes discussed at #2849

@thinkyhead
Copy link
Member

You'll have to apply the same change to every configuration file before this can be merged.

@jbrazio
Copy link
Contributor Author

jbrazio commented Feb 29, 2016

No worries, I'll also change comment style to // in order to comply with all the other comment sections.

@lrpirlet
Copy link
Contributor

lrpirlet commented Mar 2, 2016

Well, @jbrazio Yes to mark x > X is to indicate the direction X "grows"... I did propose that a long way back, the idea is that, if you center the origin in the middle of the bed (delta), it indicates how to read the diagram...
The diagram can then set and read with some clear direction (a little like a map where the North is allways pointing to the top).
@thinkyhead @Roxy-3DPrintBoard So, my printer has the origin in the back and the right of the bed... So I just need to turn the map 180 degrees before taking any conclusion about the topology...

@jbrazio
Copy link
Contributor Author

jbrazio commented Mar 3, 2016

How about this ?

  // Z Probe to nozzle (X,Y) offset, relative to (0, 0).
  // X and Y offsets must be integers.
  //
  // In the following example the X and Y offsets are both positive:
  // #define X_PROBE_OFFSET_FROM_EXTRUDER 10
  // #define Y_PROBE_OFFSET_FROM_EXTRUDER 10
  //
  //   +--- BACK --+
  // L |           | R
  // E |    (+) P  | I <-- probe (20,20)
  // F |           | G
  // T | (-) N (+) | H <-- nozzle (10,10)
  //   |           | T
  // ^ |    (-)    |
  // + |           |
  // Y O-- FRONT --+
  // (0,0) X+>

Or this ?

  // Z Probe to nozzle (X,Y) offset, relative to (0, 0).
  // X and Y offsets must be integers.
  //
  // In the following example the X and Y offsets are both positive:
  // #define X_PROBE_OFFSET_FROM_EXTRUDER 10
  // #define Y_PROBE_OFFSET_FROM_EXTRUDER 10
  //
  //            (++,++)
  //   +--- BACK --+
  // L |           | R
  // E |    (+) P  | I <-- probe (20,20)
  // F |           | G
  // T | (-) N (+) | H <-- nozzle (10,10)
  //   |           | T
  //   |    (-)    |
  //   |           |
  //   O-- FRONT --+
  // (0,0)

thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Mar 6, 2016
thinkyhead added a commit that referenced this pull request Mar 6, 2016
Update PROBE OFFSET FROM EXTRUDER comment section
@thinkyhead thinkyhead merged commit fbde764 into MarlinFirmware:RCBugFix Mar 6, 2016
thinkyhead added a commit that referenced this pull request Mar 6, 2016
@jbrazio jbrazio deleted the 2849-update_probe_position_comment branch March 6, 2016 23:27
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants