Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework intermediate idle() and manage_heater() calls in G2/G3 and G5 #3797

Merged
merged 3 commits into from May 19, 2016
Merged

Rework intermediate idle() and manage_heater() calls in G2/G3 and G5 #3797

merged 3 commits into from May 19, 2016

Commits on May 19, 2016

  1. Speedup sreen update delay 

    Speedup sreen update delay
and correct a comment.

A module division by 10 is slooooow. (powers of 2 are fast - but then you can AND a bitmask with the same result)
    @AnHardt
    AnHardt committed May 19, 2016
    Copy the full SHA
    0c4d885 View commit details
    Browse the repository at this point in the history

  2. No compromises for the manage_heater() 

    No compromises for the manage_heater(). manage_heater() will return immediately when there is nothing to do, but needs a constant detaT to work proper.
Calling idle() only every 200ms results in a display update every ~2 seconds - that should be enough.
For the other functionalities in idle() and manage_inactivity() 200ms is a lot but hopefully works.
    @AnHardt
    AnHardt committed May 19, 2016
    Copy the full SHA
    2207001 View commit details
    Browse the repository at this point in the history

  3. Remove SF_ARC_FIX from G5 (Cubic B-spline) 

    Remove SF_ARC_FIX from G5 (Cubic B-spline).
SF_ARC_FIX is a fix for G2/G3 (arcs) where Skeinforge always produced relative instead of absolute coordinates for the endpoint of an arc.
It's very unlikely this is also a problem with Cubic B-splines. More likely is copying from the G2/G3 code.
    @AnHardt
    AnHardt committed May 19, 2016
    Copy the full SHA
    e761bdb View commit details
    Browse the repository at this point in the history