Stopwatch and PrintCounter improvements #3813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch and PrintCounter classes
|
const static uint16_t j = this->saveInterval * 1000; This variable must is uint32_t. The max valor width uint16_t 65536 |
| this->data.finishedPrints++; | ||
| this->data.printTime += this->deltaDuration(); | ||
| this->saveStats(); | ||
| } |
There was a problem hiding this comment.
I got a compilation warning.
AppData\Local\Temp\builde7989c12e25d478367e8a5397818719d.tmp\sketch\printcounter.cpp: In member function 'bool PrintCounter::stop()':
AppData\Local\Temp\builde7989c12e25d478367e8a5397818719d.tmp\sketch\printcounter.cpp:169:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
Then, is
if (super::stop()) {
this->data.finishedPrints++;
this->data.printTime += this->deltaDuration();
this->saveStats();
return true;
}
else return false;better?
jbrazio
added a commit
to jbrazio/Marlin
that referenced
this pull request
May 22, 2016
Merged
nomukaiki
pushed a commit
to nomukaiki/Marlin
that referenced
this pull request
May 27, 2016
* RCBugFix: (34 commits) set_z parameters marked const EEPROM report uses G29 S3 Propose simpler probe index methods Propose simpler cel index methods Small reduction in M421 code Two index finding functions for MBL Rename CORE_AXIS_3 to NORMAL_AXIS COREYZ stepper, planner, endstop, babysteps COREYZ Conditionals, SanityCheck for only a single kinematic Add option for CoreYZ kinematics Cleanup the Marlin logo with a hires svg version Correct hardware endstops default Followup for MarlinFirmware#3813 Fixes MarlinFirmware#3809 and adds several improvements to the Stopwatch and PrintCounter classes Additional instructions for controller reverse options PID_ADD_EXTRUSION_RATE based on MarlinKimbra Conditionals and Sanity Check for SINGLENOZZLE Add "SINGLENOZZLE" extruder option Extend M421 with I and J parameters Travis CI test for MBL ...
Closed
CONSULitAS
pushed a commit
to CONSULitAS/Marlin-K8200
that referenced
this pull request
Aug 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3809 and adds several improvements to the Stopwatch and PrintCounter classes.