Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropsegments => MIN_SEGMENTS_FOR_MOVE #4666

Merged
merged 1 commit into from Aug 21, 2016

Conversation

thinkyhead
Copy link
Member

Rename this option for consistency with other configuration settings and a more accurate description of its function. As such, its value is also increased by 1.

@thinkyhead thinkyhead merged commit 1a255af into MarlinFirmware:RCBugFix Aug 21, 2016
@thinkyhead thinkyhead deleted the rc_dropsegments_adj branch August 21, 2016 03:42
@Blue-Marlin
Copy link
Contributor

Blue-Marlin commented Aug 21, 2016

MIN_SEGMENTS_FOR_MOVE is really confusing.
Actually the function is - drop segment if it has less than ? steps -> MIN_STEPS_PER_SEGMENT or MIN_STEPS_PER_MOVE

@thinkyhead
Copy link
Member Author

thinkyhead commented Aug 21, 2016

Surely dropsegments was never a good name. It clearly implies "Drop this many segments." And one is forced to ask "drop where?" "drop when?" "does drop mean forget?" So MIN_SEGMENTS_FOR_MOVE is, you have to admit, at least marginally better.

But I agree that since the value is compared with steps, the word STEPS would be better-used in the name.

thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Aug 21, 2016
@thinkyhead thinkyhead mentioned this pull request Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants