Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note suggesting RAMBo users use the RAMBo board type or platformio environment #4703

Merged
merged 1 commit into from Aug 26, 2016

Conversation

bgort
Copy link
Contributor

@bgort bgort commented Aug 25, 2016

Add note suggesting RAMBo users use the RAMBo board type or platformio environment, per #4689 (comment).

Also add note that Viki 2.0 wiring diagram v1.2 has a mistake in it;

…o environment;

Add note that Viki 2.0 wiring diagram v1.2 has a mistake in it;
@thinkyhead
Copy link
Member

thinkyhead commented Aug 26, 2016

This is fine, but educate me: Why wouldn't RAMBo users already be using BOARD_RAMBO? And if a user is that daft, why would we expect them to go reading the pins_RAMBO.h file for help?

@bgort
Copy link
Contributor Author

bgort commented Aug 26, 2016

I would assume Rambo users are using BOARD_RAMBO, generally. This note is about compiling with the 'RAMBo' board type in the Arduino IDE, or 'reprap_rambo' in platformio.ini, as opposed to the standard Mega 2560 board type.

That there's a need to use anything beyond the 'Mega 2560' option, or that 'RAMBo'/'reprap_rambo' are even options, is apparently unknown to a good number of people, including tech support where I bought my Viki2, and where I bought my RAMBo.

I agree that putting this kind of notice in pins_RAMBO.h isn't ideal, but I don't know where else it should go and I figure those needing to edit that file (which is where the use of the extended pins on a Rambo could come into play), and those in the situation I was in trying to make accessories/addons work, without luck, will see it and be saved some hassle/wasted time. It would have helped me.

@thinkyhead
Copy link
Member

Ah, sorry for my missing the point. This is a good addition.

@thinkyhead thinkyhead merged commit 3b93b79 into MarlinFirmware:RCBugFix Aug 26, 2016
@bgort
Copy link
Contributor Author

bgort commented Aug 26, 2016

No worries. Glad you included it. Think it will help people.

@thinkyhead thinkyhead mentioned this pull request Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants