Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language_de.h #6437

Merged
merged 5 commits into from
Apr 28, 2017
Merged

Update language_de.h #6437

merged 5 commits into from
Apr 28, 2017

Conversation

Kaibob2
Copy link
Contributor

@Kaibob2 Kaibob2 commented Apr 24, 2017

No description provided.

@thinkyhead
Copy link
Member

thinkyhead commented Apr 26, 2017

Just ran the script to see if any more are needed, and…

$ buildroot/share/scripts/findMissingTranslations.sh de
Building list of missing strings...
MSG_ADVANCE_K                       : de
MSG_DELTA_AUTO_CALIBRATE            : de
MSG_DELTA_HEIGHT_CALIBRATE          : de
MSG_FREE_XY                         : de
MSG_MOVING                          : de

There are some quite tricky ones which are hardly translateable.
Maybe @Sebastianv650 can review this
@Kaibob2
Copy link
Contributor Author

Kaibob2 commented Apr 26, 2017

These were exactly my problems. I tried to find the context in ultralcd.cpp but this led to nothing because of my lag of a delta printer.
So I just tried to maintain the meaning from language_en.h.
@thinkyhead Maybe it should just be merged and we'll see if someone (german with a delta) has a better idea for it.

@Roxy-3D
Copy link
Member

Roxy-3D commented Apr 28, 2017

@thinkyhead Maybe it should just be merged and we'll see if someone (german with a delta) has a better idea for it.

I think @thinkyhead will be looking at this tonight. I reviewed all of the other language Pull Requests and felt comfortable merging them. But I'll leave this one for Thinky to do. I tend to agree that even if it needs a few small tweaks... Merging it gets us closer to where it should be.

@thinkyhead
Copy link
Member

Looks good. In future we can make more allowance for those (likely quite rare) 16 character wide displays.

@thinkyhead thinkyhead merged commit dabca83 into MarlinFirmware:RCBugFix Apr 28, 2017
@thinkyhead
Copy link
Member

thinkyhead commented Apr 28, 2017

So far the messages read OK, but I have problems getting the context for the delta messages:
MSG_FREE_XY: Does it Mean Marlin will move the print head to a middle position (=away from max/min X/Y position) automatical?
MSG_DELTA_AUTO_CALIBRATE: The translation has the meaning of auto calibration, but I have no idea what gets autocalibrated here - I have no delta.
MSG_DELTA_HEIGHT_CALIBRATE: Is it for entering a value in the menu or will it execute a probing function like sending G28 Z?

@Sebastianv650 A quick search of the code reveals…

  • Menu item MSG_FREE_XY moves the effector down below the "danger zone" so that XY movement may be done.
  • Menu item MSG_DELTA_AUTO_CALIBRATE sends G33 C0 to start the auto calibration procedure with DELTA_CALIBRATION_DEFAULT_POINTS.
  • Menu item MSG_DELTA_HEIGHT_CALIBRATE sends G33 C1 to start the auto calibration procedure for height.

@Kaibob2 Kaibob2 deleted the patch-1 branch April 29, 2017 04:32
@Sebastianv650
Copy link
Contributor

Sebastianv650 commented Apr 29, 2017

  • Menu item MSG_FREE_XY moves the effector down below the "danger zone" so that XY movement may be done.
    In this case, "Abstand XY" is not a very helpful text. From a technical viewpoint, I would name this "Z-Achse Freifahren", but I'm afraid this wouldn't be more clear to 90% of the people out there. But maybe this is still better than "Abstand XY".
  • Menu item MSG_DELTA_AUTO_CALIBRATE sends G33 C0 to start the auto calibration procedure with DELTA_CALIBRATION_DEFAULT_POINTS.
    Then the translation is OK.
  • Menu item MSG_DELTA_HEIGHT_CALIBRATE sends G33 C1 to start the auto calibration procedure for height.
    Then "Delta Höhe setzen" is not good in my opinion. It has more the meaning of entering a number, like "set the nozzle temperature to 200°C". "Delta Höhe kalibrieren" would be much better, or even without the word "Delta" as there is no other height calibration option on a delta I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants