Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1.x] Add SCROLL_LONG_FILENAMES to reveal longer filenames #8020

Merged

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Oct 19, 2017

Based on #7637 by @marcio-ao — this is a longstanding feature request!
See also #8021

This PR follows the scheme of the original, scrolling up to the end of the long filename and stopping. Good enough for most. A circular scrolling option may be added later.

A change was made to tell in-place when the row has changed, using a hash of the short filename.

An option was added to prevent SDCARD_SORT_ALPHA from exploding its buffer in response to the increased long filename size.

@thinkyhead thinkyhead force-pushed the bf1_scroll_longnames branch 17 times, most recently from 0fa0b0b to 3f076ca Compare October 20, 2017 07:19
@thinkyhead thinkyhead force-pushed the bf1_scroll_longnames branch 4 times, most recently from f1ed06b to a7398a0 Compare October 21, 2017 02:18
@thinkyhead thinkyhead merged commit 1d5fb36 into MarlinFirmware:bugfix-1.1.x Oct 21, 2017
@thinkyhead thinkyhead deleted the bf1_scroll_longnames branch October 21, 2017 02:34
kForth pushed a commit to kForth/Marlin that referenced this pull request Jun 22, 2022
…gnames

[1.1.x] Add SCROLL_LONG_FILENAMES to reveal longer filenames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant