Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Self Hosting on Docker #129

Closed
3 tasks done
BeatLink opened this issue Mar 27, 2023 · 4 comments · Fixed by #153
Closed
3 tasks done

[Feature Request]: Self Hosting on Docker #129

BeatLink opened this issue Mar 27, 2023 · 4 comments · Fixed by #153
Labels

Comments

@BeatLink
Copy link

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Freetube Cordova currently does not have a docker image available to install.

Proposed Solution

Create a docker image for hosting FreeTube Cordova

Alternatives Considered

None

Issue Labels

ease of use improvement

Additional Information

No response

@OwenTruong
Copy link

OwenTruong commented Jun 28, 2023

One thing to note is that my simple and small PR does not provide a way to sync across multiple devices. The data stays on the client/browser. The Nginx container only listens for the request to send the static site to the client. The benefit of running this kind of Docker image is that it can be run in the background, easy to change port, and easy to set up for others who are more familiar with Docker than JS technologies.

I think creating sync might be doable, but difficult. My idea is that an ExpressJS server (inside the container) will be needed to handle GET/POST request for the config data. However, this will require changes to how data is routed with IndexedDB for Docker-specific builds, and might be hard to maintain.

@BeatLink
Copy link
Author

Dang. That's a shame regarding the sync implementation. If anyone has any ideas how it could be done id be keen to hear.

@absidue
Copy link

absidue commented Oct 8, 2023

The FreeTube PWA (like upstream) is a purely client side application, you can host it on any static file server, you can literally deploy it on GitHub Pages, so having a docker container for that seems slightly overkill.

@MarmadileManteater
Copy link
Owner

MarmadileManteater commented Oct 11, 2023

I'm leaving this issue closed automatically by the PR #153; there is now a Dockerfile which can be used to build a docker image if one is so inclined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants