Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: PWA - Fullscreen button not visible in portrait on mobile #298

Open
4 of 5 tasks
Nonononoki opened this issue Feb 26, 2024 · 1 comment
Open
4 of 5 tasks
Labels
B: accessibility bug Something isn't working

Comments

@Nonononoki
Copy link

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

The full screen button in the video player is not visible on narrow screen, such a phones in portrait mode.

Expected Behavior

Full screen button should always be visible on any device.

Issue Labels

accessibility issue

FreeTube Version

v0.19.1.109 Beta

Operating System Version

Android 13

Installation Method

PWA (Progressive Web App)

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

@Nonononoki Nonononoki added the bug Something isn't working label Feb 26, 2024
@MarmadileManteater
Copy link
Owner

I'm not going to get to this immediately, and the fix is, probably, going upstream since its a responsiveness issue.

The fix I'm thinking of would be to just move / remove some of the buttons in the controls. Maybe, the video progress timestamp doesn't need to be shown under a certain width. Maybe, the P-in-P button shouldn't be in the bar, etc.

The only reason this isn't a problem in the app is because it doesn't support P-in-P. When it does, this will also be an issue with the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: accessibility bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants