Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: YT links within descriptions now open an external browser #264

Closed
5 tasks done
MarmadileManteater opened this issue Dec 3, 2023 · 2 comments
Closed
5 tasks done

[Bug]: YT links within descriptions now open an external browser #264

MarmadileManteater opened this issue Dec 3, 2023 · 2 comments
Labels
B: feature stopped working bug Something isn't working

Comments

@MarmadileManteater
Copy link
Owner

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. Find a video with a valid YT link in the description
  2. Click on it
  3. A web browser is opened instead of the link being opened inside the app

Expected Behavior

All YT links within the app should prevent navigation outside the app, and should instead cause the app to navigate to that video, playlist, channel, etc.

Issue Labels

feature stopped working

FreeTube Version

v0.19.1.109

Operating System Version

Android 13, Kernel version 4.9.337-ab23415000 #1 Tue Jun 6 15:02:28 UTC 2023, Build number TQ3A.230901.001.23415000

Installation Method

.apk

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

This problem does not occur when supported links are enabled.

Nightly Build
@MarmadileManteater MarmadileManteater added the bug Something isn't working label Dec 3, 2023
@MarmadileManteater
Copy link
Owner Author

This is not an issue in the nightlies as of the new build.

MarmadileManteater added a commit that referenced this issue Apr 4, 2024
@MarmadileManteater
**Release 111**
624ba44 
##### ~~Cordova~~ Android specific changes:

- Switched away from Cordova [#101](#101 (comment))
  - Added ability to stream videos **locally** *without* proxying through invidious [#5](#5) 🥂
  - Added ability to seek in the media controls notification
  - Fixed videos stopping or stuttering when the app enters the background [#10](#10)
  - Fixed YT links not opening in app [#264](#264)
- Added ability to change where profiles/settings/playlists/history.db are located on the filesystem [#299](#299)
- Fullscreen videos now take up the entire screen instead of sharing real estate with the system UI

This release includes all of the changes from upstream release [0.20.0](https://github.com/FreeTubeApp/FreeTube/releases/tag/v0.20.0-beta).

  ...

  **Full Changelog**: 0.19.2.110...0.20.0.111
MarmadileManteater added a commit that referenced this issue Apr 4, 2024
@MarmadileManteater
**Release 111**
00a3d25 
##### ~~Cordova~~ Android specific changes:

- Switched away from Cordova [#101](#101 (comment))
  - Added ability to stream videos **locally** *without* proxying through invidious [#5](#5) 🥂
  - Added ability to seek in the media controls notification
  - Fixed videos stopping or stuttering when the app enters the background [#10](#10)
  - Fixed YT links not opening in app [#264](#264)
- Added ability to change where profiles/settings/playlists/history.db are located on the filesystem [#299](#299)
- Fullscreen videos now take up the entire screen instead of sharing real estate with the system UI

This release includes all of the changes from upstream release [0.20.0](https://github.com/FreeTubeApp/FreeTube/releases/tag/v0.20.0-beta).

  ...

  **Full Changelog**: 0.19.2.110...0.20.0.111
MarmadileManteater added a commit that referenced this issue Apr 4, 2024
@MarmadileManteater
**Release 111**
f848732 
##### ~~Cordova~~ Android specific changes:

- Switched away from Cordova [#101](#101 (comment))
  - Added ability to stream videos **locally** *without* proxying through invidious [#5](#5) 🥂
  - Added ability to seek in the media controls notification
  - Fixed videos stopping or stuttering when the app enters the background [#10](#10)
  - Fixed YT links not opening in app [#264](#264)
- Added ability to change where profiles/settings/playlists/history.db are located on the filesystem [#299](#299)
- Fullscreen videos now take up the entire screen instead of sharing real estate with the system UI

This release includes all of the changes from upstream release [0.20.0](https://github.com/FreeTubeApp/FreeTube/releases/tag/v0.20.0-beta).

  ...

  **Full Changelog**: 0.19.2.110...0.20.0.113
MarmadileManteater added a commit that referenced this issue Apr 4, 2024
@MarmadileManteater
**Release 111**
668d1ba 
##### ~~Cordova~~ Android specific changes:

- Switched away from Cordova [#101](#101 (comment))
  - Added ability to stream videos **locally** *without* proxying through invidious [#5](#5) 🥂
  - Added ability to seek in the media controls notification
  - Fixed videos stopping or stuttering when the app enters the background [#10](#10)
  - Fixed YT links not opening in app [#264](#264)
- Added ability to change where profiles/settings/playlists/history.db are located on the filesystem [#299](#299)
- Fullscreen videos now take up the entire screen instead of sharing real estate with the system UI

This release includes all of the changes from upstream release [0.20.0](https://github.com/FreeTubeApp/FreeTube/releases/tag/v0.20.0-beta).

  ...

  **Full Changelog**: 0.19.2.110...0.20.0.114
MarmadileManteater added a commit that referenced this issue Apr 4, 2024
@MarmadileManteater
**Release 115**
7890f6f 
##### ~~Cordova~~ Android specific changes:

- Switched away from Cordova [#101](#101 (comment))
  - Added ability to stream videos **locally** *without* proxying through invidious [#5](#5) 🥂
  - Added ability to seek in the media controls notification
  - Fixed videos stopping or stuttering when the app enters the background [#10](#10)
  - Fixed YT links not opening in app [#264](#264)
- Added ability to change where profiles/settings/playlists/history.db are located on the filesystem [#299](#299)
- Fullscreen videos now take up the entire screen instead of sharing real estate with the system UI

This release includes all of the changes from upstream release [0.20.0](https://github.com/FreeTubeApp/FreeTube/releases/tag/v0.20.0-beta).

  ...

  **Full Changelog**: 0.19.2.110...0.20.0.115
@MarmadileManteater
Copy link
Owner Author

This is now resolved by release 0.20.0.115.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B: feature stopped working bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarmadileManteater