Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Icon conflicts with IDE (PHPStrom/WebStorm) #32

Closed
iliyaZelenko opened this issue Mar 6, 2020 · 7 comments · Fixed by #35
Closed

The Icon conflicts with IDE (PHPStrom/WebStorm) #32

iliyaZelenko opened this issue Mar 6, 2020 · 7 comments · Fixed by #35
Labels
Type: Bug Something isn't working

Comments

@iliyaZelenko
Copy link
Contributor

Version
0.2.0

In PHPStrom and WebStorm your component Icon in conflict with my component Icon in my project.
I mean, I am prompted to import your Icon, instead of mine.

image

This is a pretty nasty problem for me and my team. You could just rename the component, please.

@iliyaZelenko iliyaZelenko added the Type: Bug Something isn't working label Mar 6, 2020
@Maronato
Copy link
Owner

Maronato commented Mar 7, 2020

This is pretty odd. Vue toastification components are not exposed and are not registered as global.

I can change the names but I also want to know if there is a way to fix it without doing that, as that would be a breaking change.

I don't use webstorm, so I'm not familiar with this behavior. VSCode does not suggest to autoimport third party's internal components, only the ones exported by the main file.

Do you know if:

  • the Icon component is the only one that causes that?
  • other plug-ins/library's internal components suffer from this as well?
  • there is a way to "hide" components from webstorm's autoimport or suggestions?

@iliyaZelenko
Copy link
Contributor Author

iliyaZelenko commented Mar 9, 2020

Yes, that too seemed strange to me.

the Icon component is the only one that causes that?

Yes

other plug-ins/library's internal components suffer from this as well?

This has not happened, although there are a lot of components

there is a way to "hide" components from webstorm's autoimport or suggestions?

I have been familiar with the web storm for a long time, as far as I know this is not possible.

A similar problem occurs for many of your components, such as Transition or Toast

image
image

An interesting point: autocomplet does not work for your component CloseButton. This is the only exception. I do not know why.

@Maronato
Copy link
Owner

I was unable to reproduce the bug but that may be my fault for not setting up webstorm properly. Can you try and see if it also happens on the latest version?

Nevertheless, I'm writing the 1.0 release which will rename all components to a better, scoped VtComponent naming scheme to avoid further problems.

@iliyaZelenko
Copy link
Contributor Author

iliyaZelenko commented Mar 11, 2020

Can you try and see if it also happens on the latest version?

I have the latest version: 2019.3.3

Nevertheless, I'm writing the 1.0 release which will rename all components to a better, scoped VtComponent naming scheme to avoid further problems.

Wonderful i will update when it comes out.

@Maronato
Copy link
Owner

The latest version of vue-toastification (now 0.9.0)

@Maronato
Copy link
Owner

@iliyaZelenko v1.0.0 is out and should fix the issue, among other things. Please give it a try and report back if you find any issues. Here is the changelog

@lock
Copy link

lock bot commented Mar 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants