Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript refactor, component namespace and more #35

Merged
merged 15 commits into from
Mar 16, 2020
Merged

Conversation

Maronato
Copy link
Owner

@Maronato Maronato commented Mar 15, 2020

1.0 release PR

Release changes:

⚠️ Breaking changes

🚀 New features

🔧 Bug fixes

📖 Documentation

📦 Bundle

@Maronato Maronato added Type: Documentation Improvements or additions to documentation Type: Enhancement New feature or request labels Mar 15, 2020
Copy link
Contributor

@tomeus tomeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good piece of work

.eslintrc.js Outdated Show resolved Hide resolved
src/components/VtToastContainer.vue Show resolved Hide resolved
src/components/VtCloseButton.vue Outdated Show resolved Hide resolved
tomeus
tomeus previously approved these changes Mar 16, 2020
Copy link
Contributor

@tomeus tomeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if you want to add any functionality, but it looks good for me.

@Maronato Maronato merged commit c5ffcc0 into master Mar 16, 2020
@Maronato Maronato deleted the v1.0-dev branch March 16, 2020 17:49
@lock
Copy link

lock bot commented Mar 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation Improvements or additions to documentation Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite plugin in Typescript The Icon conflicts with IDE (PHPStrom/WebStorm)
2 participants