-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript refactor, component namespace and more #35
Conversation
…X to icon options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good piece of work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if you want to add any functionality, but it looks good for me.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
1.0 release PR
Release changes:
hideCloseButton
removed! Now setcloseButton: false
to hide it. (Typescript refactor, component namespace and more #35) (ea1a448){ tag, children, class }
conflicts with JSX, so it was changed to{ iconTag, iconChildren, iconClass }
(Typescript refactor, component namespace and more #35) (ea1a448)examples
folder topublic
! Examples did not make sense since it was the code for the demo. (Typescript refactor, component namespace and more #35) (eb56db2)Vt
prefix! Some editors were picking up internal components by name. (Typescript refactor, component namespace and more #35) (4158311) closes The Icon conflicts with IDE (PHPStrom/WebStorm) #32🚀 New features
containerClassName
plugin option: Now custom classes can be added to containers docs (Typescript refactor, component namespace and more #35) (58c1d3e)🔧 Bug fixes
PluginOptions
was missing from the module declaration. Declaration file fixes #34 (03cd140)$updateDefaults({ container: yourHTMLElement } )
was not updating the container component, but now does without losing any state or affecting UI. (Typescript refactor, component namespace and more #35)(6428344) Thanks to @tomeus📖 Documentation
onClose
documentation:onClose
documentation was missing, even though it was implemented. docs (Typescript refactor, component namespace and more #35) (eb56db2)📦 Bundle