Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composition API #75

Merged
merged 2 commits into from Apr 26, 2020
Merged

Composition API #75

merged 2 commits into from Apr 26, 2020

Conversation

Maronato
Copy link
Owner

Description

Implements provideToast and useToast so Vue Toastification can be natively used in applications that use the new Composition API.

Also exposes a new createToastInterface method that generalizes the toast registration process and makes it possible to use Vue Toastification inside any web page that has a global Vue instance.

Working examples have been added to the examples folder.

Related Issue

Resolves #74

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Maronato Maronato added the Type: Enhancement New feature or request label Apr 26, 2020
@Maronato Maronato self-assigned this Apr 26, 2020
@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #75   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          353       356    +3     
  Branches        71        72    +1     
=========================================
+ Hits           353       356    +3     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e3c994...adcc295. Read the comment docs.

@Maronato Maronato merged commit 4931280 into master Apr 26, 2020
@Maronato Maronato deleted the composition-api branch April 26, 2020 04:28
@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composition API Support
1 participant