Fix show tags refresh (#2799)

* fix show tags fresh Signed-off-by: sharpd <davidsharp7@gmail.com> * disable show tags on version load Signed-off-by: sharpd <davidsharp7@gmail.com> --------- Signed-off-by: sharpd <davidsharp7@gmail.com>
MarquezProject · Apr 18, 2024 · d6ac3e6 · d6ac3e6
1 parent d0a4207
commit d6ac3e6
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/web/src/components/datasets/DatasetDetailPage.tsx b/web/src/components/datasets/DatasetDetailPage.tsx
@@ -105,13 +105,7 @@ const DatasetDetailPage: FunctionComponent<IProps> = (props) => {
 
   useEffect(() => {
     fetchDatasetVersions(lineageDataset.namespace, lineageDataset.name)
-  }, [lineageDataset.name])
-
-  useEffect(() => {
-    if (showTags) {
-      fetchDatasetVersions(lineageDataset.namespace, lineageDataset.name)
-    }
-  }, [showTags])
+  }, [lineageDataset.name, showTags])
 
   // if the dataset is deleted then redirect to datasets end point
   useEffect(() => {
@@ -219,6 +213,7 @@ const DatasetDetailPage: FunctionComponent<IProps> = (props) => {
                     checked={showTags}
                     onChange={() => setShowTags(!showTags)}
                     inputProps={{ 'aria-label': 'toggle show tags' }}
+                    disabled={versionsLoading}
                   />
                 }
                 label={i18next.t('datasets.show_field_tags')}