-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DatasetDao tests #314
Comments
Hey, I would like to work on it |
Hey @hjpatel16. Great to hear you'd like to help out! I'm actually fixing this issue in PR #395 (sorry, should've assigned this to myself sooner). Once merged into Is there an issue tagged with "good first issue" you'd like to pick up? |
Actually, I was looking more than "good first issue" where I would be able to code more and contribute more. Let me know if you know any specific issue which will be perfect for me |
@hjpatel16, sure! How does adding a factory method to our response models sound? Full details can be found here #309. I know the issues related to the epic are labeled as "good first issue", but these changes are non-trivial and would require writing tests, with new methods used right away in our resource classes. Let me know if that's something you're interested in. NOTE: You would need a separate PR per issue in the epic |
Yes, I would like to work on that epic. Thanks @wslulciuc, much appreciated |
Fixed #395 |
Our test coverage for
DatasetDao
is currently< 25%
, let's add some tests to get it closer to75%
codecov link: https://codecov.io/gh/MarquezProject/marquez/src/master/src/main/java/marquez/db/DatasetDao.java
The text was updated successfully, but these errors were encountered: