Update spark job name to reflect spark application name and execution node #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1191 +/- ##
=========================================
Coverage 74.44% 74.44%
Complexity 803 803
=========================================
Files 180 180
Lines 4790 4790
Branches 368 368
=========================================
Hits 3566 3566
Misses 852 852
Partials 372 372 Continue to review full report at Codecov.
|
… node Signed-off-by: Michael Collado <mike@datakin.com>
Signed-off-by: Michael Collado <mike@datakin.com>
collado-mike
force-pushed
the
spark_job_name
branch
from
602de58
to
807212c
Compare
wslulciuc
reviewed
Apr 6, 2021
| @@ -2,7 +2,7 @@ | |||
| "eventType": "COMPLETE", | |||
| "eventTime": "2021-01-01T00:00:00Z", | |||
| "run": { | |||
| "runId": "ea445b5c-22eb-457a-8007-01c7c52b6e54", | |||
| "runId": "fake_run_id", | |||
| "facets": { | |||
| "parent": { | |||
There was a problem hiding this comment.
Minor: Did you also want to update the parent runID used in the test?
wslulciuc
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
This looks great, @collado-mike! The naming convention now more closely aligns with our Airflow integration. Excited to see how a spark job launched via Airflow can be linked via to its parent runID (= the operator that submitted the spark job) and displayed in our lineage graph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change changes the job naming behavior creating a new job name for each query execution in the spark application. For each query execution, a new job is created, with a unique
runIdand a parent facet pointing to the run identified by the parameters passed into the agent.As an example, one job name I generated in testing was
orders_dump_to_gcs.execute_insert_into_hadoop_fs_relation_command, whereorders_dump_to_gcsis the spark application name andexecute_insert_into_hadoop_fs_relation_commandis the node name returned by theDataWritingCommandExecphysical plan node.