namespaces: allow '=' and ';' in names #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawel-big-lebowski
approved these changes
Apr 6, 2022
collado-mike
approved these changes
Apr 6, 2022
mobuchowski
force-pushed
the
bug/allow-additional-namespace-chars
branch
from
a11780e
to
c132f22
Compare
auto-merge was automatically disabled
April 7, 2022 12:39
Pull request was closed
mobuchowski
force-pushed
the
bug/allow-additional-namespace-chars
branch
from
c132f22
to
b583633
Compare
|
Accidentally closed, reopening |
mobuchowski
force-pushed
the
bug/allow-additional-namespace-chars
branch
from
feee49c
to
01590d1
Compare
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
mobuchowski
force-pushed
the
bug/allow-additional-namespace-chars
branch
from
01590d1
to
0696026
Compare
Codecov Report
@@ Coverage Diff @@
## main #1936 +/- ##
=============================================
+ Coverage 64.59% 78.09% +13.49%
- Complexity 184 944 +760
=============================================
Files 35 193 +158
Lines 771 5249 +4478
Branches 86 418 +332
=============================================
+ Hits 498 4099 +3601
- Misses 146 705 +559
- Partials 127 445 +318
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve bug in issue OpenLineage/OpenLineage#655 by allowing ';' and '=' in namespace names.
Signed-off-by: Maciej Obuchowski obuchowski.maciej@gmail.com