Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary updates which are deadlock prone #2531

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

pawel-big-lebowski
Copy link
Collaborator

@pawel-big-lebowski pawel-big-lebowski commented Jun 29, 2023

Problem

Fix SQL syntax that could cause deadlocks

Closes: #2530

Solution

Get rid of unnecessary updates.

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary:

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • [] You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added api API layer changes docs labels Jun 29, 2023
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
@pawel-big-lebowski pawel-big-lebowski marked this pull request as ready for review June 29, 2023 13:47
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #2531 (d8c1383) into main (1ce9aca) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2531   +/-   ##
=========================================
  Coverage     83.80%   83.80%           
  Complexity     1233     1233           
=========================================
  Files           235      235           
  Lines          5625     5625           
  Branches        270      270           
=========================================
  Hits           4714     4714           
  Misses          767      767           
  Partials        144      144           
Impacted Files Coverage Δ
api/src/main/java/marquez/db/SourceDao.java 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc merged commit 7edb1da into main Jun 29, 2023
12 checks passed
@wslulciuc wslulciuc deleted the fix-unnecessary-on-conflict branch June 29, 2023 17:41
harels pushed a commit that referenced this pull request Jun 30, 2023
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 5, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 5, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 6, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 6, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 6, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 6, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 6, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 6, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 6, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Signed-off-by: Xavier-Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Xavier-Cliquennois pushed a commit to Xavier-Cliquennois/marquez that referenced this pull request Jul 26, 2023
)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Xavier Cliquennois <Xavier-Cliquennois@users.noreply.github.com>
Signed-off-by: Xavier-Cliquennois <xavier.cliquennois@wearegraphite.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix SQL syntax that could cause deadlocks
2 participants