Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unix epoch time display in case of null endedAt value #2647

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

merobi-hub
Copy link
Collaborator

@merobi-hub merobi-hub commented Oct 10, 2023

Problem

In the case of a fresh instance of Marquez (e.g., a new user experimenting with a quickstart), using cURL to post a start event by itself causes the runs component to display the Unix epoch time in the ENDED AT column.

Solution

This makes displaying the endedAt value conditional on there being a durationMs value greater than 0. Otherwise, it will display 'N/A'.

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary: Fixes Unix epoch time display in case of null endedAt value.

Closes: #2646

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Screenshot 2023-10-10 at 17 21 40

Signed-off-by: Michael Robinson <merobi@gmail.com>
@boring-cyborg boring-cyborg bot added the web label Oct 10, 2023
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit cd5e1b1
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6525cf4f79096b0008d6f104

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #2647 (616f678) into main (fd4d1c3) will decrease coverage by 3.09%.
The diff coverage is n/a.

❗ Current head 616f678 differs from pull request most recent head cd5e1b1. Consider uploading reports for the commit cd5e1b1 to get more accurate results

@@             Coverage Diff              @@
##               main    #2647      +/-   ##
============================================
- Coverage     83.35%   80.26%   -3.09%     
+ Complexity     1295      232    -1063     
============================================
  Files           244       43     -201     
  Lines          5948      968    -4980     
  Branches        279       38     -241     
============================================
- Hits           4958      777    -4181     
+ Misses          844      162     -682     
+ Partials        146       29     -117     

see 201 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@merobi-hub merobi-hub changed the title Fixe Unix epoch time display in case of null endedAt value. Fix Unix epoch time display in case of null endedAt value Oct 10, 2023
Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @merobi-hub

@merobi-hub merobi-hub merged commit 92badb2 into main Oct 10, 2023
15 checks passed
@merobi-hub merobi-hub deleted the bug/runs/null-timestamp branch October 10, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] start event in fresh instance has Unix epoch date automatically populated in GUI
2 participants