Update dataset/dataset field tagging experience

[davidsharp7]

Problem

The Adding and deleting of tags was not providing an intuitive and seemless experience.

Solution

Based on the feedback i've changed how the datasets details/tags/info components work by introducing a switch which allows field level tags to be exposed. Refresh only now occurs when the slide toggle is true. You can add multiple tags in one go now as well.

One-line summary:

Update dataset/dataset field tagging experience.

Checklist

• You've signed-off your work
• Your changes are accompanied by tests (if relevant)
• Your change contains a small diff and is self-contained
• You've updated any relevant documentation (if relevant)
• You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
• You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
• You've included a header in any source code files (if relevant)

[netlify]

✅ Deploy Preview for peppy-sprite-186812 canceled.

Name	Link
🔨 Latest commit	3bb97d4
🔍 Latest deploy log	https://app.netlify.com/sites/peppy-sprite-186812/deploys/661f0a5e721c940008ad860c

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (17909a2) to head (ef2de7b).

❗ Current head ef2de7b differs from pull request most recent head 3bb97d4. Consider uploading reports for the commit 3bb97d4 to get more accurate results

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #2761   +/-   ##
=========================================
  Coverage     84.47%   84.47%           
  Complexity     1429     1429           
=========================================
  Files           251      251           
  Lines          6460     6460           
  Branches        299      299           
=========================================
  Hits           5457     5457           
  Misses          850      850           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[phixMe]

Why would this be a string and not a boolean?

[davidsharp7]

So the thinking is twofold - one to bring it into line with

marquez/web/src/components/datasets/DatasetDetailPage.tsx

Line 94 in 78a191b

}, [lineageDataset.name, datasets.refreshTags])

where we are refreshing based on the change in dataset name.

Second reason was for trouble shooting purposes. Based on the concatanation of namespace/datasetname/field/tag it was just easier to understand/diagnose what was happening.

[davidsharp7]

Can always change the dependency to

datasets.refreshTags === true

and change the reducer to set refreshTags to False when its updating then True on success.

[phixMe]

Ok, let's just go with what you have here.

[phixMe]

Thanks @davidsharp7

[phixMe]

We can do this a little more functionally like:

const newSelectedTags = selectedTags.filter((tag) => deletedTag !== tag);
setSelectedTags(newSelectedTags);

[phixMe]

Maybe let's make this change and I'll merge if that sounds good?

[davidsharp7]

Surely can.

[wslulciuc]

🤩

[wslulciuc]

❤️