Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt column lineage query for symlink dataset #2775

Merged

Conversation

sophiely
Copy link
Contributor

@sophiely sophiely commented Mar 22, 2024

Problem

👋 Thanks for opening a [pull request]
A dataset with a symlink and column lineage threw an error during listing dataset in a specific namespace:

java.util.NoSuchElementException: No value present
! at java.base/java.util.Optional.get(Optional.java:143)

Closes: I2776

Solution

Change column lineage query in order to take only the 'main' dataset (not the dataset created by symlink).

One-line summary:

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the api API layer changes label Mar 22, 2024
Signed-off-by: sophiely <ly.sophie200@gmail.com>
Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 5d8bfeb
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/661ef65bb9a82c0008a34b11

@sophiely sophiely force-pushed the feat/fix-column-lineage-with-symlink branch from e4b3d62 to 537cc44 Compare March 22, 2024 16:57
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (d5daf50) to head (5d8bfeb).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2775   +/-   ##
=========================================
  Coverage     84.47%   84.47%           
  Complexity     1429     1429           
=========================================
  Files           251      251           
  Lines          6460     6460           
  Branches        299      299           
=========================================
  Hits           5457     5457           
  Misses          850      850           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc added this to the 0.47.0 milestone Apr 16, 2024
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sophiely for the symlink fix for column lineage. Symlink support in Marquez is a hidden feature that only power users are aware of! I've opened #2796 and #2797 to better document and improve usage.

@wslulciuc wslulciuc merged commit 17909a2 into MarquezProject:main Apr 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants