Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Refresh + Loading States #2779

Merged
merged 3 commits into from
Mar 31, 2024
Merged

Web Refresh + Loading States #2779

merged 3 commits into from
Mar 31, 2024

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Mar 30, 2024

Problem

Users would like to refresh pages without refreshing the browser, so we've added buttons to refresh all list pages.

image > Note: Upper right corner of diagram. image

One-line summary:
Refresh button for jobs, datasets, and lineage events pages. This also will work in empty states.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@boring-cyborg boring-cyborg bot added the web label Mar 30, 2024
Copy link

netlify bot commented Mar 30, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit 715dbd4
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/66077df7a2adb700082d6b37

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (2aa578a) to head (715dbd4).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2779   +/-   ##
=========================================
  Coverage     84.47%   84.47%           
  Complexity     1429     1429           
=========================================
  Files           251      251           
  Lines          6460     6460           
  Branches        299      299           
=========================================
  Hits           5457     5457           
  Misses          850      850           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc merged commit e0a85f1 into main Mar 31, 2024
16 checks passed
@wslulciuc wslulciuc deleted the web/refresh-state branch March 31, 2024 17:40
@wslulciuc wslulciuc added this to the 0.47.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants