Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #353 Removed Create* prefix from request payloads #359

Merged
merged 1 commit into from Feb 28, 2019

Conversation

OlenaVyshnevska
Copy link
Contributor

Renamed:

  1. 'CreateJobRunRequest' class to 'JobRunRequest'
  2. 'CreateNamespaceReques' class to 'NamespaceRequest'

Modified all occurrences of the above classes to use new names.

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #359 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #359   +/-   ##
========================================
  Coverage      77.2%   77.2%           
  Complexity      398     398           
========================================
  Files            91      91           
  Lines          1044    1044           
  Branches         50      50           
========================================
  Hits            806     806           
  Misses          172     172           
  Partials         66      66
Impacted Files Coverage Δ Complexity Δ
.../java/marquez/api/resources/NamespaceResource.java 96.42% <ø> (ø) 6 <0> (ø) ⬇️
...c/main/java/marquez/api/resources/JobResource.java 88.09% <ø> (ø) 20 <0> (ø) ⬇️
...n/java/marquez/api/mappers/NamespaceApiMapper.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...main/java/marquez/api/models/NamespaceRequest.java 80% <ø> (ø) 4 <0> (?)
...rc/main/java/marquez/api/models/JobRunRequest.java 83.33% <ø> (ø) 5 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f9a36b...984c2b3. Read the comment docs.

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the quick patch, @OlenaVyshnevska.

@wslulciuc wslulciuc merged commit ac749d5 into MarquezProject:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants