Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue 344 #367

Merged
merged 5 commits into from Mar 2, 2019
Merged

Fixed issue 344 #367

merged 5 commits into from Mar 2, 2019

Conversation

hjpatel16
Copy link
Contributor

Removed the @Bind Property from DataSourceDao, DatasetDao, DbTableInfoDao, JobDao, JobRunArgsDao, JobRunDao, JobRunStateDao, JobVersionDao, NamespaceDao

@wslulciuc
Copy link
Member

@hjpatel16: I left a comment on how to fix the failing tests so we can get your PR merge, but otherwise this looks great!

@hjpatel16
Copy link
Contributor Author

Sure, Ill fix it and push the changes

@codecov
Copy link

codecov bot commented Mar 2, 2019

Codecov Report

Merging #367 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #367   +/-   ##
========================================
  Coverage      77.2%   77.2%           
  Complexity      398     398           
========================================
  Files            91      91           
  Lines          1044    1044           
  Branches         50      50           
========================================
  Hits            806     806           
  Misses          172     172           
  Partials         66      66
Impacted Files Coverage Δ Complexity Δ
src/main/java/marquez/db/JobDao.java 100% <ø> (ø) 1 <0> (ø) ⬇️
src/main/java/marquez/db/DatasetDao.java 100% <ø> (ø) 1 <0> (ø) ⬇️
src/main/java/marquez/db/JobVersionDao.java 100% <ø> (ø) 1 <0> (ø) ⬇️
src/main/java/marquez/db/JobRunDao.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...rc/main/java/marquez/api/models/JobRunRequest.java 83.33% <100%> (ø) 5 <1> (ø) ⬇️
...c/main/java/marquez/api/models/JobRunResponse.java 87.5% <0%> (ø) 7% <0%> (ø) ⬇️
src/main/java/marquez/api/models/Job.java 88.88% <0%> (ø) 8% <0%> (ø) ⬇️
...in/java/marquez/api/models/NamespacesResponse.java 60% <0%> (ø) 3% <0%> (ø) ⬇️
...rc/main/java/marquez/api/models/ErrorResponse.java 66.66% <0%> (ø) 2% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735eeb1...bd20b24. Read the comment docs.

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @hjpatel16!

@wslulciuc wslulciuc merged commit e740ded into MarquezProject:master Mar 2, 2019
@wslulciuc wslulciuc mentioned this pull request Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants