New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue 344 #367
Fixed issue 344 #367
Conversation
…oDao, JobDao, JobRunArgsDao, JobRunDao, JobRunStateDao, JobVersionDao, NamespaceDao
@hjpatel16: I left a comment on how to fix the failing tests so we can get your PR merge, but otherwise this looks great! |
Sure, Ill fix it and push the changes |
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
========================================
Coverage 77.2% 77.2%
Complexity 398 398
========================================
Files 91 91
Lines 1044 1044
Branches 50 50
========================================
Hits 806 806
Misses 172 172
Partials 66 66
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @hjpatel16!
Removed the @Bind Property from DataSourceDao, DatasetDao, DbTableInfoDao, JobDao, JobRunArgsDao, JobRunDao, JobRunStateDao, JobVersionDao, NamespaceDao