Fix issue where Icon doesn't change color when selectedColor state change #31
Conversation
…esn't get updated until reset app
| @@ -215,6 +215,7 @@ class AnimatedNavigationTiles extends StatelessWidget { | |||
| padding: items.badgePadding, | |||
| child: IconWidget( | |||
| item: items, | |||
| color: items.selectedColor, | |||
There was a problem hiding this comment.
Unnecessary color parameter: The color parameter seems redundant. The existing item property already provides the necessary color information.
| @@ -412,7 +415,7 @@ class _IconWidgetState extends State<IconWidget> | |||
|
|
|||
| animationColor = ColorTween( | |||
| begin: widget.item.backgroundColor ?? widget.item.unSelectedColor, | |||
| end: widget.item.selectedColor, | |||
| end: widget.color, | |||
There was a problem hiding this comment.
Replacing item.selectedColor with color might lead to unexpected behavior if the color parameter is not used correctly or consistently. It's unclear why this change was made without a clear explanation.
There was a problem hiding this comment.
Hi Jonathan M Nguyen,
Thanks for the PR.
I'm having trouble understanding the purpose of the added color parameter and the associated changes. It seems to duplicate functionality already provided by item.selectedColor.
Could you please clarify the reasoning behind these changes? Without a clear explanation, it's difficult to assess the potential impact on the component's behavior.
Additionally, I recommend removing the unnecessary color parameter and reverting to using item.selectedColor to maintain code simplicity and consistency.
Please let me know if you have any questions.
Fixed AnimatedBarOption where changing selectedColor state only change the textColor but doesn't change the Icon color.
Current Actual Result:
Expected Result: