Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbs up does not 'love' the track on last.fm #1830

Closed
cristianmtr opened this issue Oct 26, 2016 · 14 comments
Closed

Thumbs up does not 'love' the track on last.fm #1830

cristianmtr opened this issue Oct 26, 2016 · 14 comments

Comments

@cristianmtr
Copy link

OS:

Windows 7

Issue Descriptions:

Thumbs up in GPMDP does not 'love' the track on last.fm

Steps to Reproduce:

  • Listen to song.
  • Press the 'thumbs up' button
  • Look at last.fm profile: song is not 'loved'
@MarshallOfSound
Copy link
Owner

This is the complete opposite of #1799

Be aware it only works if you thumbs up / down the song from the player bar at the bottom. Liking / unliking a track in a playlist or the queue or such doesn't fire the love event

@cristianmtr
Copy link
Author

Tried it again just now, doesn't work

@MarshallOfSound
Copy link
Owner

@cristianmtr Is it scrobbling that song successfully?

@cristianmtr
Copy link
Author

Yes, it is.

@cristianmtr
Copy link
Author

Nobody else seeing this issue? What am I missing here?

@cristianmtr
Copy link
Author

Tried it on multiple machines, still doesn't work.

@ronilaukkarinen
Copy link
Contributor

Same here, not working.

@MarshallOfSound
Copy link
Owner

I swear it's working for me, I'll reopen and investigate

@ronilaukkarinen
Copy link
Contributor

Sorry, forgot my details.

System: Mac OS X: 10.11.6 (El Capitan)
App: V4.0.3 (via website)

Fresh install, just found your app (great progress by the way!). Last.fm scrobbles just fine, but thumbs up won't sync to loved, tried many songs. I hope this helps.

@Niklan
Copy link

Niklan commented Dec 21, 2016

System: KDE Neon (Ubuntu 16.04 i believe under hood).
App: v4.0.X (where is Pirate language was added, i don't find where app version is printed).

Same here. Thumb up via bottom panels not trigger like on Last.fm.

P.s. Also, it will be great to have setting for minimum track playback for add to statistic of last.fm. I see some delay is set, but it is not clear. What % of track, or seconds must play before scrobble is counting?

I found that 50% is required to get scrobbled and 10 second after previous scrobble, but it's not true, i think, tracks which not reach 50% also scrobbled.

@MarshallOfSound
Copy link
Owner

but it's not true, i think, tracks which not reach 50% also scrobbled.

Not sure what you mean here but the implementation is exactly following the spec in the last.fm API docs

@csc0tt
Copy link

csc0tt commented Apr 14, 2017

I just downloaded and installed this today (Windows v4.2.0) and tried using the thumbs up button in the bottom bar and, I didn't see the love on last.fm. However, I did see a duplicate track being scrobbled for two different songs I tried thumbs upping. One was already thumbs up'd and I clicked it off and back on, the other wasn't set yet and I clicked the thumbs up.

When I refreshed my profile later after the next song (to make sure it wasn't duplicating other songs) that I didn't touch the thumbs for, I noticed the the duplicates (the songs I tried to thumbs up) were gone. Maybe last.fm removed them because the timing wouldn't make it possible for me to have listened to the track twice?

@anna-is-cute
Copy link

anna-is-cute commented Apr 23, 2017

I was listening to the track "Lone Digger" and I hit the thumbs up icon, which resulted in

this

"Comics" is the next song on the album, which I started listening to after "Lone Digger."

I've never experienced hitting thumbs up in GPMDP loving the song on last.fm. I would love for this to be an option under the last.fm settings and for it to be fixed.

Oh, and macOS 10.12.5, app version 4.2.0.

@exhuma
Copy link

exhuma commented Aug 14, 2017

I just realised that this is not working for me either. I could have sworn this worked in the past (maybe this was disabled due to #1799? But maybe I'm mixing this up with a GPlay Chrome extension I had before GPMDP)

I quite like to look at both the recomendations from Last.FM and GPlay. This kind of stumped me. I just realised that I may have lost quite a lot of "loves" because of this.

@MarshallOfSound MarshallOfSound self-assigned this Aug 15, 2017
@MarshallOfSound MarshallOfSound removed their assignment Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants