D-Bus wrong volume output

[YodaEmbedding]

When the volume is at exactly 0% or 100%, the following command:

qdbus org.mpris.MediaPlayer2.google-play-music-desktop-player \
      /org/mpris/MediaPlayer2 \
      org.mpris.MediaPlayer2.Player.Volume

outputs the raw byte 0x01:

�

Expected behavior is of course either the string 0 or 1, respectively.

All other numbers between 0 and 1 are outputted correctly.

[MarshallOfSound]

@jostrander Is this one of those weird int type issues from the node-dbus library?

[jostrander]

This is probably related, but I don't have my ubuntu machine anymore to test on.

[fcastilloec]

This is indeed an upstream bug on node-dbus because of int types. On Headset we just add 1e-15 to the volume so neither a 0 or 1 are ever sent to MPRIS. In other words it would look something like this:

if (volume === 0) {
  mprisPlayer.volume = volume + 1e-15;
} else if (volume === 1) {
  mprisPlayer.volume = volume - 1e-15;
} else {
  mprisPlayer.volume = volume;
}

This code doesn't affect the volume output. Of course, we can use any value but on my tests 1e-15 is the smallest value I can use before node rounds it up to a 0 or 1