Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube Music Doesn't Automatically Skip Disliked Songs #3878

Open
3 tasks done
andrewjmetzger opened this issue Aug 19, 2020 · 10 comments
Open
3 tasks done

YouTube Music Doesn't Automatically Skip Disliked Songs #3878

andrewjmetzger opened this issue Aug 19, 2020 · 10 comments
Labels
service/ytm Related to YTM side of player
Milestone

Comments

@andrewjmetzger
Copy link

Checklist:

OS: Pop!_OS 20.04 LTS

GPMDP Version: 4.7.1 (deb)

Issue Descriptions: In YouTube Music mode, disliked songs are never skipped during playback.

Steps to Reproduce:

  1. Switch to YouTube Music mode using the button in the upper-right, or the tray icon.
  2. Using the tray icon, open Desktop settings.
  3. Select the Playback. tab, and ensure Automatically skip disliked songs is checked.
  4. Queue any song, followed by a disliked song, and then another song.
  5. Result: All three songs are played.

Expected behavior: Songs that are liked or have no rating play. Songs that are disliked do not play.

What actually happens: All songs play, even if disliked or rated with a thumbs down.

@EndangeredNayla
Copy link

Simple answer. This is google play music desktop player not youtube music desktop player. Try this

https://ytmdesktop.app/

@andrewjmetzger
Copy link
Author

Thanks for the link. However, GPMDP also supports YTM.

Until a maintainer closes YTM issues as "wontfix" or decides to drop YTM support altogether, issues like this are a valid concern for GPMDP, despite the name of the project.

See also: Issue #3841.

@andrewjmetzger
Copy link
Author

andrewjmetzger commented Aug 25, 2020

@CrankySupertoon YTM Desktop, which you linked above, does not currently support the desired feature. GPMDP does support this with GPM, but not for YTM. When you suggest an alternative, please make sure it is a comparable replacement.

EDIT: As of v1.13.0-R2, YTM Desktop now supports skipping disliked songs. See ytmdesktop/ytmdesktop#334.

@returnvisit
Copy link

me too. In YouTube Music mode, disliked songs are never skipped during playback

@Block81838
Copy link

Simple answer. This is google play music desktop player not youtube music desktop player. Try this

https://ytmdesktop.app/

This is freakin lag, a real resource killer

@andrewjmetzger
Copy link
Author

@Block81838 Agreed, although I don't see any feature-comparable alternatives, since the official site on desktop can also be a resource killer. With development of GPMDP all but ceased, it's not like we have many options.

As time goes on, I'm sure YTM Desktop will continue to improve. For now, I'd suggest pulling the development branch, where all the latest improvements are happening.

@Block81838
Copy link

@andrewjmetzger does gpmdp no longer develop?

@andrewjmetzger
Copy link
Author

Agreed, Electron is a resource killer. If I knew how, I would update GPMDP to be YTM Desktop 2.0 (or similar) and remove the GPM branding to breathe some life back into this project so that we could avoid electron altogether. Alas, I have no clue how to do any of that.

does gpmdp no longer develop?

Since Google Play Music is shutting down at the end of October 2020, this project needs a major update to shift its support to YouTube Music. Unfortunately, GPMDP's commit history shows that the last commit on 2020-08-10 was a translation patch--and nothing new has been added been added since July.

Several issues have been raised to discuss the future of this project, but with no clear word from the project maintainers as to the path forward for GPMDP, it seems that YTM Desktop is the least worst replacement for now.

@christofdamian
Copy link

Having just had to fix an issue in ytmdesktop I would be happy to see GPMDP remove Google Music and focus on YTM.
The code of GPMDP is just much nicer to work with.

@returnvisit
Copy link

returnvisit commented Oct 13, 2020 via email

@jostrander jostrander added the service/ytm Related to YTM side of player label Oct 15, 2020
@jostrander jostrander added this to the 5.0.0 milestone Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/ytm Related to YTM side of player
Projects
None yet
Development

No branches or pull requests

6 participants