Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Japanese translation #3530

Merged
merged 3 commits into from Mar 19, 2019
Merged

Improve Japanese translation #3530

merged 3 commits into from Mar 19, 2019

Conversation

yuk7
Copy link
Contributor

@yuk7 yuk7 commented Mar 18, 2019

  • Default devices are generally translated as "既定のデバイス".(ex.Windows)
  • Even in Japan, the brand "Youtube Music" remains the same.
  • The notation "イシュー" is not common in Japan.

@welcome
Copy link

welcome bot commented Mar 18, 2019

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line: - Run npm run lint locally to catch formatting errors earlier. - Include tests when adding/changing behavior. - Include screenshots and animated GIFs whenever possible. - If you added new translation strings ensure that you have added empty strings for all languages - If you added new functionality or modified existing functionality please ensure it is tested

@MarshallOfSound MarshallOfSound merged commit e0af8b1 into MarshallOfSound:master Mar 19, 2019
@welcome
Copy link

welcome bot commented Mar 19, 2019

Congrats on merging your first pull request! Have a ⭐

@MarshallOfSound
Copy link
Owner

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants