Add CRX3 support #140
Merged
Add CRX3 support #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google servers recently started sending empty replies when acceptformat=crx2,crx3 is not passed. Add the option to the URL query and switch to unzip-crx-3, which supports both CRX v2 and v3. Closes: MarshallOfSound#139
|
Can you add one such extension to the test suite to validate this change? |
|
The current version of the React Developer Tools is affected, so this is already covered by the tests. |
2Pacalypse-
added a commit
to ShieldBattery/ShieldBattery
that referenced
this pull request
Jul 15, 2020
This is only a temporary commit until electron-devtools-installer merges this PR which fixes the issue with this extension: MarshallOfSound/electron-devtools-installer#140
@MarshallOfSound does this satisfy your desire to have an extension in the CRX3 format as part of the tests? |
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
facebook-github-bot
pushed a commit
to facebook/flipper
that referenced
this pull request
Jul 17, 2020
Summary: Update electron-devtools-installer to fix issue blocking installation of dev tools for some users currently: MarshallOfSound/electron-devtools-installer#140 Reviewed By: passy Differential Revision: D22604024 fbshipit-source-id: f98d8d6e138283c54d5e1cf446b7049bb31b51a0
5 tasks
sfoster1
added a commit
to Opentrons/opentrons
that referenced
this pull request
Sep 25, 2020
e-d-i 3.1.1 includes MarshallOfSound/electron-devtools-installer#140, a fix for an issue where google bumped the version of their chrome extension format and the unpacker that r-d-i used therefore stopped working. The PR uses a new version of that unzipper library that functions. Fixes an issue where addon devtools would never be installed.
sfoster1
added a commit
to Opentrons/opentrons
that referenced
this pull request
Sep 25, 2020
e-d-i 3.1.1 includes MarshallOfSound/electron-devtools-installer#140, a fix for an issue where google bumped the version of their chrome extension format and the unpacker that r-d-i used therefore stopped working. The PR uses a new version of that unzipper library that functions. Fixes an issue where addon devtools would never be installed.
shlokamin
pushed a commit
to Opentrons/opentrons
that referenced
this pull request
Oct 1, 2020
e-d-i 3.1.1 includes MarshallOfSound/electron-devtools-installer#140, a fix for an issue where google bumped the version of their chrome extension format and the unpacker that r-d-i used therefore stopped working. The PR uses a new version of that unzipper library that functions. Fixes an issue where addon devtools would never be installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google servers recently started sending empty replies when
acceptformat=crx2,crx3 is not passed. Add the option to the URL query
and switch to unzip-crx-3, which supports both CRX v2 and v3.
Closes: #139