chore(app-shell): bump electron-devtools-installer to 3.1.1 #6637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-d-i 3.1.1 includes MarshallOfSound/electron-devtools-installer#140, a fix for an issue where google bumped the version of their chrome extension format and the unpacker that r-d-i used therefore stopped working. The PR uses a new version of that unzipper library that functions. Fixes an issue where addon devtools would never be installed.
sfoster1
deleted the
chore_app-shell-bump-electron-devtools-installers
branch
shlokamin
pushed a commit
that referenced
this pull request
Oct 1, 2020
e-d-i 3.1.1 includes MarshallOfSound/electron-devtools-installer#140, a fix for an issue where google bumped the version of their chrome extension format and the unpacker that r-d-i used therefore stopped working. The PR uses a new version of that unzipper library that functions. Fixes an issue where addon devtools would never be installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e-d-i 3.1.1 includes
MarshallOfSound/electron-devtools-installer#140,
a fix for an issue where google bumped the version of their chrome
extension format and the unpacker that r-d-i used therefore stopped
working. The PR uses a new version of that unzipper library that
functions.
Fixes an issue where addon devtools would never be installed.