Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new devtools for VueJS 3 #183

Merged
merged 2 commits into from
Apr 18, 2021
Merged

new devtools for VueJS 3 #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65130aa
feat(feature): new devtools for VueJS 3
barisbora Apr 18, 2021
378c9aa
feat(fix): fixes devtools name
barisbora Apr 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ import installExtension, {
EMBER_INSPECTOR, REACT_DEVELOPER_TOOLS,
BACKBONE_DEBUGGER, JQUERY_DEBUGGER,
ANGULARJS_BATARANG, VUEJS_DEVTOOLS,
REDUX_DEVTOOLS,
VUEJS3_DEVTOOLS, REDUX_DEVTOOLS,
CYCLEJS_DEVTOOL, MOBX_DEVTOOLS,
APOLLO_DEVELOPER_TOOLS,
} from 'electron-devtools-installer';
Expand Down
4 changes: 4 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,10 @@ export const VUEJS_DEVTOOLS: ExtensionReference = {
id: 'nhdogjmejiglipccpnnnanhbledajbpd',
electron: '>=1.2.1',
};
export const VUEJS3_DEVTOOLS: ExtensionReference = {
id: 'ljjemllljcmogpfapbkkighbhhppjdbg',
electron: '>=1.2.1',
};
export const REDUX_DEVTOOLS: ExtensionReference = {
id: 'lmhkpmbekcpmknklioeibfkpmmfibljd',
electron: '>=1.2.1',
Expand Down
5 changes: 5 additions & 0 deletions test/testdata/knownExtensions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
JQUERY_DEBUGGER,
ANGULARJS_BATARANG,
VUEJS_DEVTOOLS,
VUEJS3_DEVTOOLS,
REDUX_DEVTOOLS,
CYCLEJS_DEVTOOL,
APOLLO_DEVELOPER_TOOLS,
Expand Down Expand Up @@ -36,6 +37,10 @@ const knownExtensions = [
...VUEJS_DEVTOOLS,
description: 'Vue.js devtools',
},
{
...VUEJS3_DEVTOOLS,
description: 'Vue.js devtools',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'Vue.js devtools',
description: 'Vue.js 3 devtools',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's invalidate the test file, given description should be same the the extension description

electron-devtools-installer/test/install_spec.ts

Line 72 in 19fd4dd

) as any) as string).should.be.equal(extensionName);

},
{
...REDUX_DEVTOOLS,
description: 'Redux DevTools',
Expand Down