Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong dir include if tag CONFIGURATION_NAME is set #25

Closed
es20490446e opened this issue Jun 20, 2023 · 8 comments
Closed

Wrong dir include if tag CONFIGURATION_NAME is set #25

es20490446e opened this issue Jun 20, 2023 · 8 comments
Labels

Comments

@es20490446e
Copy link

While building, if you add the flag CONFIGURATION_NAME, headers install into:

/usr/include/c++utilities-whatever/c++utilities

Instead of:

/usr/include/c++utilities-whatever

@Martchus
Copy link
Owner

This is correct behavior and important so includes like #include <c++utilities/application/global.h> still work - because that's how one is supposed to use headers of this library from external projects. If you use the CMake module or pkg-config correctly then the include path should be added automatically. Otherwise just add it as needed.

@Martchus
Copy link
Owner

Martchus commented Jun 20, 2023

Considering that Arch Linux and Debian packaging is using this feature I doubt it is buggy. If you nevertheless think so please provide more details to reproduce.

@es20490446e
Copy link
Author

Let me have a look 👀

@es20490446e
Copy link
Author

es20490446e commented Jun 21, 2023

Okay, I figured it out by digging into the qtutilities Debian package and CMakeLists.txt.

While running cmake I had to add the flag CONFIGURATION_PACKAGE_SUFFIX.

I don't understand that while reading buildvariables.md.

It says:

  • Set CONFIGURATION_PACKAGE_SUFFIX to use libraries built with CONFIGURATION_NAME.

I guess it shall say something like:

  • Set PACKAGE_NAMESPACE_PREFIX to look for library headers with a custom prefix.
  • Set CONFIGURATION_PACKAGE_SUFFIX to look for library headers with a custom suffix.

@es20490446e es20490446e reopened this Jun 21, 2023
@Martchus
Copy link
Owner

It should not say anything about headers because that's too specific. This is about all kinds of files the library consists of (the library itself, CMake modules, scripts, …).

PACKAGE_NAMESPACE_PREFIX should have documentation. This feature has been contributed by Debian and they didn't add documentation at the time.

@es20490446e
Copy link
Author

It can say: "for example headers".

@Martchus
Copy link
Owner

I've just pushed a documentation change. So I suppose this issue can be closed.

@es20490446e
Copy link
Author

Thanks! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants