Fix building on Mac OS X/macOS #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martchus
requested changes
Jul 20, 2019
Without project(), compiler flags like -std=gnu++17 are not applied for non-Apple clang on Mac OS X/macOS.
|
Thanks fixed! |
Martchus
approved these changes
Jul 20, 2019
Martchus
added a commit
to Martchus/reflective-rapidjson
that referenced
this pull request
Jul 20, 2019
Martchus
added a commit
to Martchus/geocoordinatecalculator
that referenced
this pull request
Jul 20, 2019
Martchus
added a commit
to Martchus/tagparser
that referenced
this pull request
Jul 20, 2019
Martchus
added a commit
to Martchus/tageditor
that referenced
this pull request
Jul 20, 2019
Martchus
added a commit
to Martchus/videodownloader
that referenced
this pull request
Jul 20, 2019
Martchus
added a commit
to Martchus/passwordfile
that referenced
this pull request
Jul 20, 2019
Martchus
added a commit
to Martchus/passwordmanager
that referenced
this pull request
Jul 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without project(), compiler flags like -std=gnu++17 are not applied
for non-Apple clang on Mac OS X/macOS.
For a more detailed explanation, see the commit message for a similar case - macports/macports-ports@98445d6.
Also, according to CMake document [1]:
That explains why the project() command in cmake/modules/BasicConfig.cmake does not always work.
[1] https://cmake.org/cmake/help/latest/command/project.html#command:project