-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i686-w64-mingw32 build crashes as of v1.4.10 #220
Comments
Same for me on a new install. Appears for a moment then immediately crashes |
@GeB666 Is your OS also 32-bit? |
@tomasz1986 No, its 64-bit |
@GeB666 Ok, so your OS is 64-bit. And what version of Syncthing Tray are you using (32-bit or 64-bit)? Considering @tomasz1986 filed #217 I assume the 64-bit version is generally working. It also works for me. So your issue might be a different one and you need to provide more information. @tomasz1986 Can you use the CLI (e.g. to print the help text or to use the CLI of the built-in Syncthing)? Does it show anything in the terminal when starting from a terminal via the CLI wrapper? (If you use MSYS2 you can also just use the normal binary instead of the CLI wrapper.) Note that the 32-bit version requires an i686 CPU (and wouldn't work if you only have e.g. i586). |
Looks like the v1.4.11 i686 release crashes in WINE when opening the about dialog:
This is also reproducible with v1.4.10. This is not reproducible with v1.4.9 so there's definitely a regression between v1.4.9 and v1.4.10 and probably the crash I'm able to reproduce has the same source than your crash. |
There were indeed no changes in Qt (as also the Qt 5 builds are affected in the very same way and I haven't updated Qt 5 at all between those builds). There were also no relevant changes in the code that crashes. Maybe the toolchain update from mingw-w64-gcc-12.2.0-1-x86_64 to mingw-w64-gcc-13.1.0-1-x86_64 (https://gitlab.archlinux.org/archlinux/packaging/packages/mingw-w64-gcc/-/commit/025acaaa02145a395d3a87cf5f10f9ab1d693c8b) causes this regression. This would be easy to cross-check by building v1.4.11 with the older toolchain. This would be the next step for me to investigate. Let's see when I'll come around to do that, so feel free to try it out yourself meanwhile. |
Unfortunately, there is no output at all when trying to run the CLI executable (although |
I now had the change to test natively under Windows and there it indeed crashes even sooner. That's also the case on a 64-bit Windows and a newer version of Windows so I simplified the issue title. It does not crash instantly, though. As you've already mentioned, printing |
The resulting binaries no longer crash when ran via WINE as they did before¹. Qt 6 packages (6.6.1 was built with GCC 13.1.0) has not been rebuilt yet as this doesn't seem to be needed. A test on Windows still needs to be done. ¹ Martchus/syncthingtray#220 (comment))
I've just been updating GCC to 13.2.1 (now using my own build instead of Arch Linux's 13.1.0 build, see Martchus/PKGBUILDs@12153c8) and I have rebuilt Syncthing Tray. In WINE it already no longer crashes. I'll update the binaries in the release section when it also looks good under Windows (for now you'll find binaries on https://martchus.no-ip.biz/repo/arch/ownstuff/os/x86_64). I haven't rebuilt Qt 6 because apparently rebuilding Syncthing Tray itself already does the trick. Maybe it is a problem with one of the libraries that come from GCC or a miscompilation affecting just a unit of Syncthing Tray itself. |
Looks like the binaries created using GCC 13.2.1 work fine under Windows. So I'm considering this issue resolved. (I created https://gitlab.archlinux.org/archlinux/packaging/packages/mingw-w64-gcc/-/issues/6 as a follow-up to get Arch Linux's packaging fixed but for the sake of building Syncthing Tray I can just use my own GCC build.) |
I can confirm that the fixed version works! Thank you very much. |
Relevant components
syncthingctl
)libsyncthing
)Environment and versions
syncthingtray
,qtutilities
andc++utilities
: 1.4.10/11, N/A, N/ABug description
Syncthing Tray used to work with no issues up to v1.4.9. However, when trying to run v1.4.10 or v1.4.11, the program only shows up in background for 1-2 seconds, and then it crashes immediately with no graphical output. Nothing is recorded in the Windows Event Viewer too.
I suspect that the issue may be related to the specific version of the OS which is Windows 10 Enterprise LTSC 2019 x86. However, Qt6 does state that they support "Windows 10 (1809 or later)" which is exactly the version here. On the other hand, the problem may also be related to the OS being 32-bit, however I've got no other device running Windows x86 to confirm the suspicion. I may try doing it on a 32-bit VM later on if necessary.
Edit: The Qt5 versions crashes the same way, so it's not about Qt.
Steps to reproduce
Expected behavior
The program should open and run as is the case with v1.4.9 and older versions.
Screenshots
Additional context
The text was updated successfully, but these errors were encountered: