-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Sync Of Remote Folder Complete" setting doesn't seem to do anything #232
Comments
Sounds like a bug, indeed. I'll have to see whether I can reproduce it. Note that the notification about the local sync is expected to show immediately after the scan if enabled. Of course you should nevertheless also get a notification once the remote device has completed the sync. |
I could not really reproduce it. I first tried with both notification types enabled: When making a local modification that is big enough to take a few seconds to synchronize I get the following behavior:
When making a local modification that is very small so it is synced in an instant I get the following behavior:
It is strange that the order in which the notifications occur was changed in the second test. I don't know enough about Syncthing's internal event handling to have an explanation for it. Syncthing Tray is merely evaluating events in the order they come in via Syncthing's event API. Note that I conduced both tests multiple times and the results were always consistent. It is not ideal that notifications are replacing each other. Unfortunately Qt's notification API doesn't allow to tweak that. For GNU/Linux I've already implemented the notification handling on my own to avoid Qt's limitations. Not sure whether I'm willing to spend the effort for Windows as well. I tested it again with only one of the notifications about concluded syncs enabled. Regardless which I disable, I now get not notifications anymore at all. This is clearly a bug. |
This was just broken in the way that the setting for local notifications was used in both cases. This change will fix it: df01c05 With this change and when only enabling notifications for remote syncs the notification about remote syncs is not replaced and shown long enough to be well regognizable. With both settings enabled there's still the problematic replacing behavior but apparently my build with Qt 6.7.0 seems to behave differently in the way that now both notifications are shown in the panel. I also added logging on the console for easier debugging. This also shows that definitely both notifications are generated, e.g.:
|
Thank you so much! 🙏🙌 I’ll test it with the next release :) |
Relevant components
syncthingctl
)libsyncthing
)Environment and versions
Client 1:
syncthingtray
(1.4.13),qtutilities
andc++utilities
: …, …, …Client 2:
Bug description
For background, I'm using syncthing tray to sync my obsidian/logseq DB across my devices, and I'm trying to achieve a balance where notifications are present but not overwhelming. I would like to receive a notification when a remote device (i.e. the one that is receiving my PC's changes) finishes syncing. It seems that
sync of remote folder complete
(found in Settings > Tray > Notifications) would do what I want (unless I'm misunderstanding its use or syncthing terminology) but currently I've not been able to trigger a notification when this option is checked.Steps to reproduce
sync of local folder complete
andsync of remote folder complete
options are set:Synchronization of local folder FOLDER_NAME complete
sync of local folder complete
option is set:Synchronization of local folder FOLDER_NAME complete
(Same as the above)sync of remote folder complete
option is set:sync of local folder complete
andsync of remote folder complete
options are set:Synchronization of PC on iPhone complete
sync of local folder complete
option is set:Synchronization of PC on iPhone complete
(Same as the above)sync of remote folder complete
option is set:I've also tried the same scenario as above with a SteamDeck instead of an iPhone. I've installed
SyncThingy v0.7.4
from the Discover store which came with Syncthing v1.27.3. The resulting notifications are the same in both casesExpected behavior
According to https://docs.syncthing.net/intro/getting-started.html:
The “local device” is the one you are configuring, viewing status for, etc., while the “remote device” is the other machine
.With the remote devices being the device on the receiving end, I would expect current notifications to be split between both
sync of local folder complete
/sync of remote folder complete
options, instead ofsync of local folder complete
managing both of them. In other words,Synchronization of PC on iPhone complete
should be issued whensync of remote folder complete
options is checked.Additional notes
I've not been able to trigger any notifications when only the
sync of remote folder complete
option is set.The text was updated successfully, but these errors were encountered: