Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable scanning/syncing icon overlays #76

Closed
2 of 6 tasks
tomasz1986 opened this issue Oct 19, 2020 · 6 comments
Closed
2 of 6 tasks

Add an option to disable scanning/syncing icon overlays #76

tomasz1986 opened this issue Oct 19, 2020 · 6 comments

Comments

@tomasz1986
Copy link
Contributor

tomasz1986 commented Oct 19, 2020

Relevant components

  • Standalone tray application (based on Qt Widgets)
  • Plasmoid/applet for Plasma desktop
  • Dolphin integration
  • Command line tool (syncthingctl)
  • Integrated Syncthing instance (libsyncthing)
  • Backend libraries

Is your feature request specific to a certain platform/environment? Please specify.

No.

Is your feature request related to a problem? Please describe.

Right now, it is possible to switch on and off the following notifications.

image

I think that it would be also useful to have a tick box to disable scanning and syncing notifications all together. The reason is that when having tons of folders and devices, there is syncing and scanning going on basically all the time. This makes the icon go back and forth changing its status constantly, which becomes distracting very quickly.

In addition to the above, personally I am more interested whether Syncthing is actually running rather than what specifically is happening at the moment (especially considering the aforementioned situation with a large number of folders and devices). In this case, the icon serves mainly a purpose to confirm that Syncthing is on and doing its job, and also to give a warning when something brakes.

Describe the solution you'd like

I would like to have a switch to disable syncthing/scanning notifications, and thus have only a static icon displayed, except for when something else happens, e.g. a disconnect or an error.

Describe alternatives you've considered

I do not think that there is any alternative right now, apart maybe from a hack to override the default scanning/syncing icon overlays with transparent or empty icons.

Additional context

image

@Martchus
Copy link
Owner

Martchus commented Oct 19, 2020

I would like to have a switch to disable syncthing/scanning notifications

Note that with "notifications" a popup like this speech bubble is meant: https://doc.qt.io/qt-5/qsystemtrayicon.html#details
But from your further descriptions I assume you're actually talking about the icon itself. I suppose this setting actually falls under the "Icons" tab where I'd add another column to show/hide the "extra bubble" at the bottom-right corner.

@tomasz1986
Copy link
Contributor Author

tomasz1986 commented Oct 19, 2020

Hmm, you are actually right. I thought that the icon overlay was meant by "notifications", the reason being that I have actually not seen any speech bubbles from Syncthing Tray 😦. I have now enabled all notifications, but still there is nothing other than the icon change e.g. when a device disconnects or a sync completes.

These are my settings, and the OS is Windows 10.

image

@Martchus
Copy link
Owner

For me the notifications work on Windows 10. Maybe they are blocked/hidden by some notification setting of Windows itself in your case.

when a device disconnects

There's no notification for that. The "disconnect" checkbox refers to a disconnect by the tray application from Syncthing's REST API.

The styling on your screenshots looks a bit odd as well. It looks like the "Windows" style. Did you select that intentionally or did the "WindowsVista" style not work for you? I'm just asking because that relates to the platform integration plugin which is also responsible for the notifications.

@tomasz1986
Copy link
Contributor Author

tomasz1986 commented Oct 19, 2020

There's no notification for that. The "disconnect" checkbox refers to a disconnect by the tray application from Syncthing's REST API.

This is what I meant. I am sorry for the wording. I meant a state when Syncthing has been shut down, and the address specified in the configuration is inaccessible.

The styling on your screenshots looks a bit odd as well. It looks like the "Windows" style. Did you select that intentionally or did the "WindowsVista" style not work for you? I'm just asking because that relates to the platform integration plugin which is also responsible for the notifications.

Yes, I am using a high-contrast theme, but the system itself has a lot of group policies set too, so I will try testing this on a clean Windows installation and come back with the results soon.

Edit: It was a problem with my system. Nothing to do with the theme, but rather with one of the Windows services. The notifications do show properly now. I should have tested on a clean system first before writing about it. I have modified the title so that it is in line with what I am actually asking for.

@tomasz1986 tomasz1986 changed the title Add an option to disable scanning/syncing notifications Add an option to disable scanning/syncing icon overlays Oct 19, 2020
Martchus added a commit that referenced this issue Dec 23, 2020
…status

* See #74
* TODO: Better add distinct status e.g. "RemoteSynchronizing"?
* TODO: Add UI and configuration
* TODO: Maybe use an enum here instead of a boolean as it is also wanted
        by other users to have *less* states
        (see #76)?
Martchus added a commit that referenced this issue Dec 31, 2020
* Allow configuring the information to consider for computing the overall
  status via SyncthingStatusComputionFlags
    * Add flag to allow considering the status of remote devices for
      #74
    * Show only plain "idle" status when no flags are present for
      #76
* Set the default flags to keep the default behavior as-is
Martchus added a commit that referenced this issue Jan 1, 2021
@Martchus
Copy link
Owner

The current release allows to disable this within the connection settings. You can now choose for each connection configuration what information should be considered to compute the overall status. In your case you would uncheck everything.

@tomasz1986
Copy link
Contributor Author

Thank you very much. Although I must say that I have got kind of used to the icons and simply do not notice them anymore 😉. Still, I have tested the newest version and everything seems to work as supposed.

The issue can be closed now, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants