Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support signature validation of AppImage via AppImageLauncher #91

Closed
1 of 7 tasks
akwala opened this issue Apr 7, 2021 · 4 comments
Closed
1 of 7 tasks

Support signature validation of AppImage via AppImageLauncher #91

akwala opened this issue Apr 7, 2021 · 4 comments

Comments

@akwala
Copy link

akwala commented Apr 7, 2021

Relevant components

  • Standalone tray application (based on Qt Widgets)
  • Plasmoid/applet for Plasma desktop
  • Dolphin integration
  • Command line tool (syncthingctl)
  • Integrated Syncthing instance (libsyncthing)
  • Backend libraries
  • Installation/update

Environment and versions

  • Versions of syncthingtray, qtutilities and c++utilities: syncthingtray-1.1.4-Build39.1.glibc2.17-x86_64.AppImage, …, …
  • Qt version: 5.12.8
  • C++ compiler (name and version): …
  • C++ standard library (name and version): …
  • Operating system (name and version): Kubuntu 20.04

(Will provide missing info if relevant.)

Bug description
When verifying downloaded file, AppImageLauncher complains that AppImage is not signed.

Steps to reproduce

  1. Right-click SyncthingTray launcher in the application menu.
  2. Select 'Update AppImage'.
  3. In AppImageLauncher dialog, check the option to remove old version after update.

Expected behavior
AppImageLauncher installs the new version and removes the old one.

Screenshots
image

Additional context
Add any other context about the problem here.

@akwala akwala added the bug label Apr 7, 2021
@Martchus
Copy link
Owner

Martchus commented Apr 7, 2021

This never worked. A signature for the AppImage is simply not provided so far. I have never used/tested AppImageLauncher so this is not supported at this point and I'm not sure whether it is worth it. Looks like the tool consumes the repository maintained via OBS directly. Not sure how or whether I can improve this considering it may be a limitation of OBS.

Note that this ticket is almost a duplicate of #88 so see my comment there.

@Martchus
Copy link
Owner

Martchus commented Apr 7, 2021

Oh, and "Qt version: 5.12.8" in the ticket description makes me laugh. I hope you're aware that the AppImage can not use the system-provided Qt for the sake of compatibility. It actually uses the good old Qt 5.6 (which I blame for any bugs only reproducible within the AppImage).

@Martchus Martchus changed the title Signature validation problem: AppImage not signed. Support signature validation of AppImage via AppImageLauncher Apr 7, 2021
@akwala
Copy link
Author

akwala commented Apr 7, 2021

This never worked. A signature for the AppImage is simply not provided so far. I have never used/tested AppImageLauncher so this is not supported at this point and I'm not sure whether it is worth it. Looks like the tool consumes the repository maintained via OBS directly. Not sure how or whether I can improve this considering it may be a limitation of OBS.

May be possible to disable/suppress the Update AppImage item in the launcher's context-menu. The digiKam launcher, for instance, doesn't have it -- not sure if this can be done when creating the AppImage.

@stale
Copy link

stale bot commented Feb 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 8, 2022
@stale stale bot closed this as completed Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants