-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode file names are not supported when writing to tag #81
Comments
What do you mean with "Manually changing to the ASCII character set"? Are you simply changing the filename to contain only ASCII-characters or are you changing the code page setting for the process? Which version/build of Tag Editor is this and which version/build of Windows are you running it on? Which code page do you use? Is it also happening with the later Qt 5 based build? Is the CLI working when using a decent terminal¹? I'm just wondering because I've already fixed that problem at some point. ¹ Since you're using |
Likely a regression introduced by e277070e9cc855f927ffcb0eec974a2dc8d52776. |
I'm using tageditor-qt6-3.6.1-x86_64-w64-mingw32.exe.zip The code page is automatically switched to UTF-8 after executing the TagEditor The same problem exists in powershell. I installed v3.5.0 on chocolatey can successfully write to the unicode file. |
No problem. I suppose you've provided enough information now - especially because I could pin it down to Martchus/tagparser@e277070.
Right, that's the default behavior of Tag Editor described in the linked README section I've already mentioned (https://github.com/Martchus/tageditor#windows-specific-issues).
Yes, as mentioned it is a recent regression. So I recommend to use the older version for now. (Of course I'll be fixing the problem. It will just take a few days as it involves testing on a Windows system, WINE is apparently no help here.) |
The problem should be fixed by: Martchus/tagparser@4f22179 You can try the development build: https://martchus.no-ip.biz/repo/experimental/win/tageditor-issue-81.exe |
The write is already successful. Here's another question, you see if need to open a new issue. Open the song, do nothing, just click Save.
Id3v1 is also generated using the command line. Neither version can set the song title for Chinese. There is the song. |
The warning is likely just that the added ID3v1 tag can not represent some of the entered values. Since the ID3v1 tag is only acting as fallback for compatibility that should be ok. Of course you can disable the creation of an ID3v1 tag in the GUI settings or via a CLI option (see README). Note sure what the problem with the GUI's behavior is. That it takes over values from ID3v2 to ID3v1 is also expected. The comment doesn't look different except that That the app crashes on an unhandled exception in the end is definitely a bug. However, maybe there's really an invalid multi-byte sequence specified by you. |
So far Tag Editor only uses Latin-1 in ID3v1 tags as some software has problems when putting UTF-8 there and Latin-1 seems to be the accepted default. Maybe it makes more sense to open it up for UTF-8 at this point. (It can already deal with existing UTF-8 values and if you'd use the C++ library directly you'd also be able put UTF-8 values in.) Note that ID3v1 hasn't been invented with support for different character sets in mind. So maybe in your case it is the best to disable ID3v1 creation. I'd mention it serves as a fallback for older software not capable of reading ID3v2 tags. However, if that leads to software accidentally interpreting data in a wrong character set as you're using non-Latin-1 characters I'd say you might be better of without it after all. |
Thanks, I will remove ID3v1 in later work. |
I suppose I can close this issue as the original problem has been fixed and ID3v1 is just not a good idea when using non-ASCII characters anyways. |
When the file name contains unicode characters, it cannot be written. Manually changing to the ASCII character set can be written.
![1647426112363_cmd](https://user-images.githubusercontent.com/6565860/158568934-db75a8e1-74c9-47cc-b712-ea48c7d3032a.png)
The text was updated successfully, but these errors were encountered: