Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rating tag for MP3 and Opus #84

Closed
stax76 opened this issue Jun 15, 2022 · 11 comments
Closed

Support rating tag for MP3 and Opus #84

stax76 opened this issue Jun 15, 2022 · 11 comments
Assignees

Comments

@stax76
Copy link

stax76 commented Jun 15, 2022

MP3 has no official rating support, but MediaMonkey, MusicBee, Strawberry Music Player, Windows File explorer and probably many other apps have agreed on a compatible convention, so it would make sense to support it in this way.

@Martchus
Copy link
Owner

If you could just tell me what the convention looks like (or send me a link to the specification or an example file) that should be easy to implement. I assume Strawberry Music Player means taglib? So if you cannot find any technical details I could still do some testings with that and also dig into taglib's code.

@Martchus
Copy link
Owner

Oh, you're the author of StaxRip. I used that myself some years ago :-)

@stax76
Copy link
Author

stax76 commented Jun 15, 2022

Nowadays, I work on mpv.net, which I use for video, but want to use it also for music, currently migrating.

Found something on Wikipedia:

https://en.wikipedia.org/wiki/ID3?oldformat=true#ID3v2_star_rating_tag_issue

My files are tagged like so:

1star: POPULARIMETER: MusicBee|1|0
2star: POPULARIMETER: MusicBee|64|0
3star: POPULARIMETER: MusicBee|128|0
4star: POPULARIMETER: MusicBee|196|0
5star: POPULARIMETER: MusicBee|255|0

@stax76
Copy link
Author

stax76 commented Jun 15, 2022

Sample file:

sample.zip

more info:

MediaArea/MediaInfo#620

mpv-player/mpv#10291

@Martchus
Copy link
Owner

Ok, I suppose I remember the POPULARIMETER from reading the ID3v2 standard. It is just not implemented yet.

Martchus added a commit to Martchus/tagparser that referenced this issue Jun 15, 2022
Martchus added a commit to Martchus/tagparser that referenced this issue Jun 15, 2022
@Martchus Martchus self-assigned this Jun 15, 2022
@Martchus
Copy link
Owner

While the tag field is standard, the string representation with the |-separator is "custom". However, it seems other tools already use it as well so I'll be using it as well. I started implementing it. It'll likely be ready for the next release.

Martchus added a commit to Martchus/tagparser that referenced this issue Jun 18, 2022
@stax76
Copy link
Author

stax76 commented Jun 18, 2022

Thank you.

I've also many Opus files from YouTube, it seems that is commonly handled with the Vorbis comment RATING using a 0-100 scale.

quodlibet/quodlibet#3533

@stax76 stax76 changed the title Support rating MP3 tag Support rating tag for MP3 and Opus Jun 18, 2022
@Martchus
Copy link
Owner

Then it makes sense to implement it in Vorbis comments as well. However, I'm currently still implementing the ID3v2 field which is a bit more involved as it actually also supports a user and a play counter.

I suppose I'll likely will allow editing the string value in the format you've mentioned within the CLI and GUI which will allow you to edit the raw rating value. Implementing a selector with stars that internally sets an appropriate rating value for the current tag format would make sense as well but that's of course also more work.

@Martchus
Copy link
Owner

It is implemented on master for ID3v2 and Vorbis comments. So the field can be edited as string value. If you want to test it, make sure you also have the latest commits from https://github.com/Martchus/tagparser.

@Martchus
Copy link
Owner

Martchus commented Jul 8, 2022

Closing as there was no further response.

@Martchus Martchus closed this as completed Jul 8, 2022
@stax76
Copy link
Author

stax76 commented Jul 8, 2022

Thanks for the new feature and the new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants